Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android/IOS - App is crashed when you tap on the unread message indicator #8945

Closed
kbecciv opened this issue May 11, 2022 · 6 comments
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kbecciv
Copy link

kbecciv commented May 11, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to the app and log in with account A
  2. Send a message from Account B, using another device to account A
  3. Check message in Account A
  4. Verify that the unread message indicator appears at the top of the page
  5. Tap on the unread message indicator

Expected Result:

App is redirected to a new unread message

Actual Result:

App is crashed when you tap on the unread message indicator

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS
  • Android

Version Number: 1.1.57-12

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

log.txt

Bug5567344_Record_2022-05-11-14-44-38_4f9154176b47c00da84e32064abf1c48.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label May 11, 2022
@kbecciv kbecciv changed the title Android/IOS - App crashed when you tap on the unread message indicator Android/IOS - App is crashed when you tap on the unread message indicator May 11, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented May 11, 2022

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@luacmartins
Copy link
Contributor

I see the error below. Seems to be happening in this call.

Screenshot_1652306720

@marcochavezf
Copy link
Contributor

Yup, the scrollToBottomAndUpdateLastRead is not bound to this, creating a PR

@chiragsalian
Copy link
Contributor

This should be resolved on version 1.1.57-15. i'd like it to be staging tested so,
@kbecciv, can you retest and if it passes then remove deployBlocker and check if off the checklist? 🙇‍♂️

@chiragsalian chiragsalian reopened this May 12, 2022
@chiragsalian
Copy link
Contributor

Looks like it was tested and checked off the list. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants