Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-04-25 #8777

Closed
francoisl opened this issue Apr 25, 2022 · 63 comments
Closed

Deploy Checklist: New Expensify 2022-04-25 #8777

francoisl opened this issue Apr 25, 2022 · 63 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@francoisl
Copy link
Contributor

francoisl commented Apr 25, 2022 •
edited by chiragsalian
Loading

Release Version: 1.1.57-17
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@mvtglobally mvtglobally added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Apr 26, 2022
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.57-2 🚀

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Apr 26, 2022
@OSBotify
Copy link
Contributor

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.57-3 🚀

@Julesssss
Copy link
Contributor

I marked #8783 as NOT a blocker, as it's not that important overall. It'll get triaged as usual though.

@francoisl
Copy link
Contributor Author

Hi @mvtglobally, how's it going with the checklist? Anything I can help with to move it forward?

@mvtglobally
Copy link

80%done. Will be updating the list in a little bit

@mvtglobally
Copy link

@francoisl Team is still working through some of the PRs to complete all platforms coverage.
So far logged Deploy Blocker - #8791

@neil-marcellini neil-marcellini mentioned this issue Apr 27, 2022
Merged
1 task
@OSBotify
Copy link
Contributor

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.57-4 🚀

@OSBotify
Copy link
Contributor

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.57-4 has been deployed to staging 🎉

@mvtglobally
Copy link

@francoisl Regression is completed
#8738 (comment)
#8743 is failing due to #8787. Since its repro in PROD checking off
We are re-testing #8656 as per last message

@mvtglobally
Copy link

#8656 is pass after retest. Checking off

@francoisl
Copy link
Contributor Author

Cool, thanks. Going to follow up on #8738.
Additionally, #8682 and #8713 are also still unchecked, can you take a look please?

@mvtglobally
Copy link

#8682. We are facing issue with the last step. Rest seem ok. #8682 (comment)
#8713 is failing #8822. But since this is a new feature, I think we can check it off?

@marcaaron
Copy link
Contributor

Found an issue with #8329 helping to resolve it in this PR #8827

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 29, 2022
@Stutikuls
Copy link

Stutikuls commented May 2, 2022 •
edited
Loading

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #8538, #8613, #8635, #8656, #8680, #8691, #8713, #8726, #8732, #8738, #8767, #8803
Logged Issues - #8432, #8434, #8433, #8395, #8463, #8616, #8430, #8530, #8388, #8432, #8434, #8433, #8395, #8560, #8555, #8395, #8398, #8385, #8400, #8392, #8465, #8620, #8667, #8525, #8555, #8388, #8560, #8525, #8555, #8560, #8527, #8615, #8385, #8556, #8430, #8556, #8430, #8619, #8624, #8481, #8624, #8616, #8671
Note: #8746 (Client: Currently there's no way for Applause to test our P2P payment flows, so you can ignore this for now as per the Client's message)

@mvtglobally
Copy link

@sketchydroide
Hope we can deploy soon. 2 Deploy Blockers still open
Based on this #8682 (comment) Checking off
#8713 is failing #8822. But since this is a new feature, I think we can check it off?

@mvtglobally mvtglobally mentioned this issue May 3, 2022
Merged
89 tasks
@sketchydroide
Copy link
Contributor

sketchydroide commented May 3, 2022 •
edited
Loading

#8713 is failing #8822. But since this is a new feature, I think we can check it off?

@marcaaron and maybe @trjExpensify any input if we can check #8713?

@sketchydroide
Copy link
Contributor

I will take a look at #8791 to see if we can unblock it

@trjExpensify
Copy link
Contributor

@marcaaron and maybe @trjExpensify any input if we can check #8713?

Yeah, Marc closed #8822 last night as it's a feature in dev as part of the offline project.

@mvtglobally
Copy link

@sketchydroide pls tag me once #8791 is ready to validate.
#8329 is not repro. not sure if internal fix was already pushed.
Just waiting for these last 2 issues to get a new build

@marcaaron marcaaron mentioned this issue May 3, 2022
Merged
45 tasks
@marcaaron
Copy link
Contributor

PR related to #8329 has been merged now, but doesn't seem like it was CP'd to staging.

I'm not really understanding how it could not be reproducible when last tested if the code linked to the original PR made it to staging.

@OSBotify
Copy link
Contributor

OSBotify commented May 3, 2022

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.57-5 🚀

@OSBotify
Copy link
Contributor

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.57-12 has been deployed to staging 🎉

@chiragsalian
Copy link
Contributor

Checked off the following since it was just me testing stuff on staging.
#8906
#8909
#8912
#8916

@sketchydroide
Copy link
Contributor

@sketchydroide, was this CP by you to add around 30 tasks to the QA checklist intentional - #8871?

No it was not intencional, to create those many new tasks, I just did the merge

I think one of the cherry picks was just to try to get the process working again, as it had been stuck with an error updating the version

@NikkiWines
Copy link
Contributor

NikkiWines commented May 10, 2022 •
edited
Loading

Checking off deploy blocker #8922 as it appears to be a known issue with a fix in the works.

@roryabraham
Copy link
Contributor

roryabraham commented May 10, 2022 •
edited
Loading

It seems like something unexpected happened with this checklist. Why were so many new PRs added? Were they all CP'd or did we somehow deploy main to staging again, despite the checklist being locked?

@chiragsalian
Copy link
Contributor

Oh btw discussed with rory 1:1. Many new PRs were added because of the CP of #8871. I discussed it with andre too and it was not intentional and it looks like pushed up a lot of changes in that CP. Definitely not an intended affect but to make the best of the situation we'll continue to QA the new PR and do regression testing as well to ensure things are in a good place.

@OSBotify
Copy link
Contributor

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.57-14 🚀

@OSBotify
Copy link
Contributor

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.57-14 has been deployed to staging 🎉

@chiragsalian
Copy link
Contributor

Update. These blockers have been addressed and i've asked for a retest before checking them off,
#8924
#8926
#8945

There's just one more blocker remaining and we'll address it tomorrow.

@mvtglobally
Copy link

mvtglobally commented May 12, 2022 •
edited
Loading

@chiragsalian Regressions is almost complete. We will retest above fixes and update in the morning.

Progress so far:
Deploy Blockers
#8922
#8924
#8926
#8945
#8947

#8733 is failing due to #8930
#8758 is failing due to #8932. not a blocker, checking off
#8778 is failing due to #8956. not a blocker, checking off
#8826 is failing due to #8951. not a blocker, checking off

Issues logged
#8920
#8922
#8923
#8927
#8929
#8930
#8931
#8942
#8943
#8951
#8956
#8960

@mvtglobally
Copy link

mvtglobally commented May 12, 2022 •
edited
Loading

Checking off
#8924
#8926
#8945

@thesahindia
Copy link
Member

Just a heads up that we can check off #8968
Because it won't be reproducible after #8962 gets fixed.

@luacmartins
Copy link
Contributor

Here's the fix for #8947

@OSBotify
Copy link
Contributor

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.57-16 🚀

@chiragsalian chiragsalian mentioned this issue May 12, 2022
Closed
@OSBotify
Copy link
Contributor

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.57-16 has been deployed to staging 🎉

@chiragsalian chiragsalian mentioned this issue May 12, 2022
Merged
88 tasks
@melvin-bot melvin-bot bot closed this as completed May 12, 2022
@chiragsalian chiragsalian reopened this May 12, 2022
@OSBotify
Copy link
Contributor

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.57-17 🚀

@OSBotify
Copy link
Contributor

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.57-17 has been deployed to staging 🎉

@chiragsalian
Copy link
Contributor

The checklist is being a little buggy for me. Can you check or consider these done,

  1. [CP Staging] bind scrollToBottomAndUpdateLastRead to "this" #8957. (It has been tested from its deploy blocker issue)
  2. Fix connect with Plaid on mobile #8969. (It has been tested from its deploy blocker issue)
  3. Login- Error is not highlighted in red when typing a password not meet the requirements #8968. (its a dupe of an earlier item)

I've asked for a retest of the following deploy blockers since the CP for them is now on staging. Once tested it can be checked off the list and the issue can be closed.

  1. Android - Connect bank account - Unable to connect with Plaid option, page is skipping #8947
  2. Log in - "Set Password" button should be disable when field is blank #8962

So the only thing remaining is #8963 and we're currently working on it.

@mvtglobally
Copy link

@chiragsalian we are re-testing

@chiragsalian
Copy link
Contributor

chiragsalian commented May 12, 2022 •
edited
Loading

Some more updates:

  1. iOS - Notifications - New message is not displayed in offline mode #8963 - No longer a blocker, can you check it off.
  2. Add platform to each network request in addition to referer #8771 - tested internally, so can you check it off.
  3. Correct some improper code patterns #8733 - Looks like its dependent on Chat - Markdown is lost when pasting a text that contained Markdown in slack #8930, since neither are really blockers we can check that off too.

Edit: mvtglobally suggested me to try the checklist in incognito and it worked for me so i checked off these items.

@mvtglobally
Copy link

Checking off #8962 #8947 - retest Passed

@chiragsalian
Copy link
Contributor

Awesome, thank you. Okay looks like we're all clear. Due to some important meetings today we're not deploying today but we'll deploy early tomorrow 🙂

@Stutikuls
Copy link

Stutikuls commented May 13, 2022 •
edited
Loading

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #8742, #8753, #8756, #8759, #8766
Logged Issues - #8605, #8527, #8618, #8485, #8625, #8554, #8385, #8624, #8556, #8484, #8479, #8527, #8480, #8485, #8555, #8524, #8485, #8618, #8463, #8671, #8481, #8624, #8616, #8670, #8619, #8388, #8667, #8668, #8525, #8669, #8555, #8624, #8557, #8621, #8557, #8618, #8527, #8555, #8619, #8480, #8619, #8624, #8385, #8560, #8555, #8614, #8387, #8387, #8556, #8617, #8522, #8618, #8983
Note: #8770 (Client: Currently there's no way for Applause to test our P2P payment flows, so you can ignore this for now as per the Client's message)

@chiragsalian
Copy link
Contributor

:shipit:

@SumitDiyora
Copy link

SumitDiyora commented May 16, 2022 •
edited
Loading

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #8789, #8796, #8801, #8803, #8805, #8813, #8830, #8836, #8853, #8854, #8857, #8858, #8862, #8906, #8909, #8912, #8916
Logged Issues - #8430, #8463, #8387, #8615, #8385, #8614, #8617, #8619, #8480, #8618, #8413, #8624, #8485, #8430, #8463, #8616, #8385, #8555, #8614, #8387, #8615, #8525, #8434, #8433,#8432, #8463, #8430, #8624, #8485, #8485, #8434, #8478, #8433, #8432, #8434, #8485, #8385, #8555, #8614, #8387, #8480, #8615, #8385, #8614, #8617, #8619, #8480, #8485, #8387, #8388, #8623, #8485, #8669, #8555, #8393, #8579, #8625, #8554, #8484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests