Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Long press on hyperlink not always displayed Copy URL to clipboard title #8960

Closed
kbecciv opened this issue May 12, 2022 · 8 comments
Closed
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented May 12, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing PR: #8815

Action Performed:

  1. Go to https://staging.new.expensify.com/ and log in with any account
  2. Navigate to chat conversation
  3. Send any hyperlinked text
  4. Long press in hyperlinked text

Expected Result:

Long press on hyperlink displayed Copy URL to clipboard title

Actual Result:

Long press on hyperlink not always displayed Copy URL to clipboard title

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web

Version Number: 1.1.57.12

Reproducible in staging?: Yes

Reproducible in production?: No 9new feature)

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5567927_Record_2022-05-12-02-39-12.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 12, 2022

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@danieldoglas
Copy link
Contributor

It can be External.

@melvin-bot melvin-bot bot removed the Overdue label May 17, 2022
@danieldoglas danieldoglas added the External Added to denote the issue can be worked on by a contributor label May 17, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 17, 2022

Triggered auto assignment to @trjExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@trjExpensify
Copy link
Contributor

@kbecciv re: the platform is this specifically on Android mWeb or iOS as well?

CC: @eVoloshchak as it seems like this PR didn't quite work.

@eVoloshchak
Copy link
Contributor

eVoloshchak commented May 17, 2022

CC: @eVoloshchak as it seems like this PR didn't quite work.

@trjExpensify
This issue isn't connected to my PR, it was present before
It's still open #8311
Before submitting my PR i raised a concern here, but was told i could submit a PR since that's a separate issue

Thanks for looking into it. It is a different issue than the one we are trying to solve here. So you don't have to fix that in this PR.

I also stated that in the PR description, in the Screenshots/mWeb section

I also researched #8311, it is present on mWeb and Native platforms, but it's somewhat different on these platforms: on mWeb it shows wrong context menu for all links, on native it shows wrong menu only if message contains text and a link

@trjExpensify
Copy link
Contributor

Okay got it, thanks for that added context. If we've got #8311, do we need this issue open as well?

@eVoloshchak
Copy link
Contributor

eVoloshchak commented May 17, 2022

Okay got it, thanks for that added context. If we've got #8311, do we need this issue open as well?

Not sure if you were asking me, but imo this one is a duplicate

@trjExpensify
Copy link
Contributor

Cool, cool. I'm going to close this out. Thanks! @danieldoglas, let me know if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

4 participants