Open old dot links with openOldDotLink() function #8769

mateusbra · 2022-04-25T20:16:13Z

Details

We are going to use the openOldDotLink() function when we have oldDot links, it will open the oldDot link with our account logged in.

Fixed Issues

$ #7909

Tests

Launch the app
Open the report with Concierge
Click on any link Concierge sends to you.

Old dot links:
4. It should open an old dot URL with the user logged in.

New dot links:
4. If link is a new dot link it should navigate to a screen within the app.

Other links:
4. Whatever other link(not new dot nor old dot) should open in a new tab.

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Launch the app
Open the report with Concierge
Click on any link Concierge sends to you.

Old dot links:
4. It should open an old dot URL with the user logged in.

New dot links:
4. If link is a new dot link it should navigate to a screen within the app.

Other links:
4. Whatever other link(not new dot nor old dot) should open in a new tab.

Screenshots

Web

Gravacao.de.Tela.2022-04-26.as.23.00.06.mov

Mobile Web

2022-04-25.17-31-12.mp4

Gravacao.de.Tela.2022-04-27.as.01.38.07.mov

Desktop

Gravacao.de.Tela.2022-04-27.as.00.54.15.mov

iOS

Ios.mov

Android

2022-04-25.17-26-39.mp4

rushatgabhane · 2022-04-26T05:05:31Z

@mateusbra Kindly add screenshots for all platforms, thanks!!

rushatgabhane

Looks good and tests well, just a few minor changes

src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js

rushatgabhane · 2022-04-26T15:16:12Z

src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js

@@ -22,14 +24,15 @@ const AnchorRenderer = (props) => {
    const attrHref = htmlAttribs.href || '';
    const internalExpensifyPath = (attrHref.startsWith(CONST.NEW_EXPENSIFY_URL) && attrHref.replace(CONST.NEW_EXPENSIFY_URL, ''))
        || (attrHref.startsWith(CONST.STAGING_NEW_EXPENSIFY_URL) && attrHref.replace(CONST.STAGING_NEW_EXPENSIFY_URL, ''));
+    const oldDotPath = attrHref.startsWith(CONFIG.EXPENSIFY.EXPENSIFY_URL) && attrHref.replace(CONFIG.EXPENSIFY.EXPENSIFY_URL, '');


@mateusbra we should also take care of staging path right?

do we really need it? I mean, will we have staging url paths being used on the app?
We need the staging path for New expensify urls because when we are on staging we need to navigate over the app,but as we are talking about the old dot path, I think we won't need it at all.

If you think we need I can add it.

you're right, it isn't needed because we aren't using staging url

rushatgabhane

~~@iwiznia looks good, and test well!!~~

Edit: some changes required

rushatgabhane

@mateusbra

This part could be DRYed up too.

App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js

Lines 42 to 53 in 3a41612

    
           if (!HTMLEngineUtils.isInsideComment(props.tnode)) { 
        
               // This is not a comment from a chat, the AnchorForCommentsOnly uses a Pressable to create a context menu on right click. 
        
               // We don't have this behaviour in other links in NewDot 
        
               // TODO: We should use TextLink, but I'm leaving it as Text for now because TextLink breaks the alignment in Android. 
        
               return ( 
        
                   <Text 
        
                       style={styles.link} 
        
                       onPress={() => Linking.openURL(attrHref)} 
        
                   > 
        
                       <TNodeChildrenRenderer tnode={props.tnode} /> 
        
                   </Text> 
        
               );

You could set the link for all 3 cases using some ifelse. And then return the component.
Please lemme know if you have any questions

mateusbra · 2022-04-27T20:37:16Z

Sorry, did't get you @rushatgabhane , you mean we should do something like?

    if (internalNewExpensifyPath || internalExpensifyPath || !HTMLEngineUtils.isInsideComment(props.tnode)) {
        return (
            <Text
                style={styles.link}
                onPress={() => (internalNewExpensifyPath ? Navigation.navigate(internalNewExpensifyPath) : internalExpensifyPath ? Link.openOldDotLink(internalExpensifyPath) : Linking.openURL(attrHref))}
            >
                <TNodeChildrenRenderer tnode={props.tnode} />
            </Text>
        );
    }

rushatgabhane · 2022-04-27T21:02:12Z

@mateusbra I meant something like

if (x) link = exfy.org
else if (y) link = new.exfy.com
else if (z) link = exfy.com

if (link) return <Text onPress=link>

Idk if it's better than what we already had. But we can always revert.

mateusbra · 2022-04-27T21:39:38Z

I tryed doing something like this, but it doesn't assign the function to the variable link, it execs the function instead.

let link;
        if(internalNewExpensifyPath){
            link = Navigation.navigate(internalNewExpensifyPath);
        }
        else if(internalExpensifyPath){
            link = Link.openOldDotLink(internalExpensifyPath)
        }
        else if(!HTMLEngineUtils.isInsideComment(props.tnode)){
            link = Linking.openURL(attrHref);
        }

am I doing something wrong?

rushatgabhane · 2022-04-27T21:45:05Z

src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.js


    // If we are handling a New Expensify link then we will assume this should be opened by the app internally. This ensures that the links are opened internally via react-navigation
    // instead of in a new tab or with a page refresh (which is the default behavior of an anchor tag)
-    if (internalExpensifyPath) {
+    if (internalNewExpensifyPath || internalExpensifyPath) {


but it doesn't assign the function to the variable link, it execs the function instead.

@mateusbra my bad, we can't do that.
Let's move internalExpensifyPath to it's own branch statement for some readability.

Let me know what you think of the comments I added

I like the comment

rushatgabhane

@iwiznia Looks good!

#### PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

iwiznia · 2022-05-03T11:48:30Z

I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)

In this case the "failure" scenarios would be:

Opening a link in newDot
Opening a link that's not oldDot nor newDot

Can you please add those tests?

mateusbra · 2022-05-03T13:27:47Z

added!

OSBotify · 2022-05-03T16:01:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-05-09T20:03:33Z

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2022-05-13T16:12:29Z

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

open old dot links with openOldDotLink() function

7465c12

mateusbra requested a review from a team as a code owner April 25, 2022 20:16

melvin-bot bot requested review from iwiznia and rushatgabhane and removed request for a team April 25, 2022 20:16

rushatgabhane suggested changes Apr 26, 2022

View reviewed changes

mateusbra and others added 2 commits April 26, 2022 23:34

Merge branch 'Expensify:main' into openOldDotLinks

56a72e3

change variable names

3a41612

rushatgabhane approved these changes Apr 27, 2022

View reviewed changes

rushatgabhane suggested changes Apr 27, 2022

View reviewed changes

rushatgabhane reviewed Apr 27, 2022

View reviewed changes

move internalExpensifyPath to it's own branch statement

d3fa8e0

rushatgabhane approved these changes Apr 28, 2022

View reviewed changes

iwiznia approved these changes May 3, 2022

View reviewed changes

iwiznia merged commit 5f6d8db into Expensify:main May 3, 2022

OSBotify mentioned this pull request May 10, 2022

Deploy Checklist: New Expensify 2022-04-25 #8777

Closed

mallenexpensify mentioned this pull request May 11, 2022

[HOLD for payment 2022-06-01] [$2000] Request a call is redirecting to the link - reported by @adeel0202 #7909

Closed

This was referenced May 11, 2022

mWeb - Chat - Download icon is not active for mp4 and mov files. #8943

Closed

Revert "Open old dot links with openOldDotLink() function" #8952

Merged

Stutikuls mentioned this pull request May 12, 2022

[med] Chrome + Jaws: Screen reader announces extra information on text fields. #8617

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Open old dot links with openOldDotLink() function #8769

Open old dot links with openOldDotLink() function #8769

mateusbra commented Apr 25, 2022 •

edited

Loading

rushatgabhane commented Apr 26, 2022 •

edited

Loading

rushatgabhane left a comment

rushatgabhane Apr 26, 2022

mateusbra Apr 27, 2022 •

edited

Loading

rushatgabhane Apr 27, 2022

rushatgabhane left a comment •

edited

Loading

rushatgabhane left a comment •

edited

Loading

mateusbra commented Apr 27, 2022

rushatgabhane commented Apr 27, 2022 •

edited

Loading

mateusbra commented Apr 27, 2022

rushatgabhane Apr 27, 2022 •

edited

Loading

mateusbra Apr 27, 2022

mateusbra Apr 27, 2022

rushatgabhane Apr 28, 2022

rushatgabhane left a comment •

edited

Loading

iwiznia commented May 3, 2022

mateusbra commented May 3, 2022

OSBotify commented May 3, 2022

OSBotify commented May 9, 2022

OSBotify commented May 13, 2022

	if (!HTMLEngineUtils.isInsideComment(props.tnode)) {
	// This is not a comment from a chat, the AnchorForCommentsOnly uses a Pressable to create a context menu on right click.
	// We don't have this behaviour in other links in NewDot
	// TODO: We should use TextLink, but I'm leaving it as Text for now because TextLink breaks the alignment in Android.
	return (
	<Text
	style={styles.link}
	onPress={() => Linking.openURL(attrHref)}
	>
	<TNodeChildrenRenderer tnode={props.tnode} />
	</Text>
	);

Open old dot links with openOldDotLink() function #8769

Open old dot links with openOldDotLink() function #8769

Conversation

mateusbra commented Apr 25, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

rushatgabhane commented Apr 26, 2022 • edited Loading

rushatgabhane left a comment

Choose a reason for hiding this comment

rushatgabhane Apr 26, 2022

Choose a reason for hiding this comment

mateusbra Apr 27, 2022 • edited Loading

Choose a reason for hiding this comment

rushatgabhane Apr 27, 2022

Choose a reason for hiding this comment

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

mateusbra commented Apr 27, 2022

rushatgabhane commented Apr 27, 2022 • edited Loading

mateusbra commented Apr 27, 2022

rushatgabhane Apr 27, 2022 • edited Loading

Choose a reason for hiding this comment

mateusbra Apr 27, 2022

Choose a reason for hiding this comment

mateusbra Apr 27, 2022

Choose a reason for hiding this comment

rushatgabhane Apr 28, 2022

Choose a reason for hiding this comment

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

#### PR Reviewer Checklist

iwiznia commented May 3, 2022

mateusbra commented May 3, 2022

OSBotify commented May 3, 2022

OSBotify commented May 9, 2022

OSBotify commented May 13, 2022

mateusbra commented Apr 25, 2022 •

edited

Loading

rushatgabhane commented Apr 26, 2022 •

edited

Loading

mateusbra Apr 27, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Apr 27, 2022 •

edited

Loading

rushatgabhane Apr 27, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading