Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Open old dot links with openOldDotLink() function" #8952

Merged
merged 1 commit into from
May 12, 2022

Conversation

thienlnam
Copy link
Contributor

@thienlnam thienlnam commented May 11, 2022

#7909

Reverts #8769 to fix #8943, and #8923

QA Steps:

Retest action steps for #8943 and #8923 and ensure they do not happen anymore

@thienlnam thienlnam requested a review from a team as a code owner May 11, 2022 21:12
@thienlnam thienlnam self-assigned this May 11, 2022
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from joelbettner and removed request for a team May 11, 2022 21:12
Copy link
Contributor

@joelbettner joelbettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thienlnam Can you put some QA steps in for this?

@thienlnam thienlnam requested a review from joelbettner May 12, 2022 17:33
@thienlnam
Copy link
Contributor Author

Just added a note to retest the issues that occurred from this PR being merged into staging

@joelbettner joelbettner merged commit 6afed2a into main May 12, 2022
@joelbettner joelbettner deleted the revert-8769-openOldDotLinks branch May 12, 2022 22:39
@joelbettner
Copy link
Contributor

joelbettner commented May 12, 2022

@thienlnam ping me if you want me to CP this to staging for ya. I think today we are in a DBS mode because of the earnings call and wanting everything to remain stable. But, I THINK we could make an exception for CPing something to staging. Let me know what you think and how time sensitive this is.

OSBotify pushed a commit that referenced this pull request May 12, 2022
Revert "Open old dot links with openOldDotLink() function"

(cherry picked from commit 6afed2a)
@thienlnam
Copy link
Contributor Author

thienlnam commented May 12, 2022

@joelbettner I thought PRs with the CP Staging label automatically got deployed to staging in App / Did we change this for the earnings call? It's not that time sensitive, should be fine as long as it gets deployed to staging before the other changes get deployed to production

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @joelbettner in version: 1.1.58-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mWeb - Chat - Download icon is not active for mp4 and mov files.
3 participants