-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Open old dot links with openOldDotLink() function" #8952
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thienlnam Can you put some QA steps in for this?
Just added a note to retest the issues that occurred from this PR being merged into staging |
@thienlnam ping me if you want me to CP this to staging for ya. I think today we are in a DBS mode because of the earnings call and wanting everything to remain stable. But, I THINK we could make an exception for CPing something to staging. Let me know what you think and how time sensitive this is. |
Revert "Open old dot links with openOldDotLink() function" (cherry picked from commit 6afed2a)
@joelbettner I thought PRs with the CP Staging label automatically got deployed to staging in App / Did we change this for the earnings call? It's not that time sensitive, should be fine as long as it gets deployed to staging before the other changes get deployed to production |
🚀 Deployed to staging by @joelbettner in version: 1.1.58-0 🚀
|
🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀
|
#7909
Reverts #8769 to fix #8943, and #8923
QA Steps:
Retest action steps for #8943 and #8923 and ensure they do not happen anymore