Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-05-13 #8991

Closed
64 tasks done
OSBotify opened this issue May 13, 2022 · 19 comments
Closed
64 tasks done

Deploy Checklist: New Expensify 2022-05-13 #8991

OSBotify opened this issue May 13, 2022 · 19 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 13, 2022 •
edited by SumitDiyora
Loading

Release Version: 1.1.60-2
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 13, 2022
@neil-marcellini
Copy link
Contributor

@thesahindia reported that #8966 breaks the bank account pages. #8993 will fix it.

@chiragsalian
Copy link
Contributor

Looks like we found a really nasty bug on production - #8994.

@Expensify/applauseleads i'm not sure how this bug was missed in the regression testing but if there is no check for this in the regression testing would you guys be able to add one now. Additionally is it possible to work on this checklist with a bit of urgency? Only because the sooner we get the checklist cleared, the sooner we can get the fix for the production issue deployed.

@mvtglobally
Copy link

@chiragsalian We are seeing a lot of issues right now and logging them in a few min.
I will check on #8994. in a few

@isagoico
Copy link

isagoico commented May 13, 2022 •
edited
Loading

@chiragsalian Checked the deploy blocker issue above and we currently don't haven any regression steps that cover scrolling to the top of the conversation and verifying everything load as expected. I'm creating a ticket to add this scenario to TestRail ASAP

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.60-2 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.60-2 has been deployed to staging 🎉

@chiragsalian
Copy link
Contributor

Update, the fixes for these two have been deployed to staging. Can you test and check it off the checklist when you get the chance? 🙇‍♂️

  1. Android - VBA - App is crashed after tap Connect bank account #8992
  2. Older report comments are not loaded once we scroll to the top - reported by @santhosh-sellavel #8994

@roryabraham
Copy link
Contributor

roryabraham commented May 14, 2022 •
edited
Loading

Just CP'd #8998, which actually fixes three deploy blockers:

I think the common thread between all three is that you're trying to open a new chat, and when it first renders, it doesn't have a name yet, which causes a crash.

h/t @Santhosh-Sellavel

@roryabraham
Copy link
Contributor

I was able to verify #7620 on staging, checking it off

@mvtglobally
Copy link

@chiragsalian @roryabraham Regression is complete. We are finishing up CP retests now
Deploy Blockers
#8992
#8996
#8997
#9004

PR #8436 is failing due to #9004, #9009, #9005
PR #8494 is failing due to #8997. We are retesting
PR #8948 is failing due to #9008. Not a blocker checking off

Issues logged
#8995
#9003
#9005
#9008
#9009
#9010
#9013
#9014
#9015
#9016
#9017
#9018
#9019

@mvtglobally
Copy link

Checking off #8994, #8993, #9002
#8996
Tested #8998 and its Pass

@roryabraham
Copy link
Contributor

Looks like we may need to retest:

@mvtglobally
Copy link

#8436 was failing due to #9004. Since its resolved, I think we can check off. Let me know what do you think @roryabraham #9009, #9005 are not blockers (same PR)

#8992 is pass, checking off

@AndrewGable
Copy link
Contributor

Looks like only one QA remains before deploying? Let me know!

@mvtglobally
Copy link

@AndrewGable, its done.
#8436 was failing due to #9004. Since its resolved, I think we can check off. Let me know what do you think as #9009, #9005 are not blockers

@AndrewGable
Copy link
Contributor

I agree, mind checking it off and I will start the deploy? Thanks!

@mvtglobally
Copy link

Done 🚀

@AndrewGable
Copy link
Contributor

:shipit:

@SumitDiyora
Copy link

SumitDiyora commented May 17, 2022 •
edited
Loading

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #8571, #8886, #8898, #8901, #8909, #8912, #8916, #8966, #8976
Logged Issues - #8524 ,#8388, #8546, #8418, #8667,#8620, #8393, #8616, #8671, #8388, #8624, #8478, #8555, #8618, #8560, #8555, #8387, #8385, #8385, #8387, #8625, #8554, #8484, #8385, #8620, #8418, #8524, #8527, #8387, #8388, #8387,#8669, #8624, #8555,#8618,#8624,#8485, #8668, #8555, #8624, #8618, #8621, #8522, #8667, #8668, #8385, #8618, #8669, #8525, #8620, #8579, #8625, #8554, #8484, #8624, #8622, #8618, #8546, #8669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@AndrewGable @chiragsalian @neil-marcellini @applausebot @mvtglobally @isagoico @roryabraham @OSBotify @SumitDiyora