Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return response to fix signInWithShortLivedToken() #8886

Merged
merged 2 commits into from
May 6, 2022

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented May 5, 2022

Details

Related to @aldo-expensify's discovery in this comment -> #8865 (comment)

Tests

  • Not sure how to test this since I don't know what the reproduction is, but the code looks fine.

  • Test for regressions and make sure the /transition works correctly from OldDot > NewDot

  • Verify that no errors appear in the JS console

PR Review Checklist

PR Reviewer Checklist

  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • iOS / native
    • Android / native
    • iOS / Safari
    • Android / Chrome
    • MacOS / Chrome
    • MacOS / Desktop
  • I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
    • I verified any copy / text shown in the product was added in all src/languages/* files
    • I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • Any functional components have the displayName property
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn’t already exist
    • The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

QA Steps

The objective is to get the url that takes us to NewDot with a short-lived token, then reuse it after a minute (the token expires after a minute)

  1. Log in old Dot with an account that has a Workspace
  2. Go to Settings > Policies > Group
  3. Click an existing workspace so it takes you to NewDot. This will open a new tab with the URL with the short-lived token, be quick and copy it. It should look like: https://new.expensify.com/transition?accountID=XX&email=XXX&shortLivedToken=XXXXX
  4. Expected result: You should be logged in successfully in New Dot
  5. Log out from New Dot
  6. Wait a bit more than a minute
  7. Open the URL with the short-lived token that we saved in step 3.
  8. Verify that you don't have this error in chrome console:
    image

You will see an endless spinner in a white screen, but that is expected for now.

Screenshots

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
marcaaron Marc Glasser
@marcaaron marcaaron requested a review from aldo-expensify May 5, 2022 18:44
@marcaaron marcaaron requested a review from a team as a code owner May 5, 2022 18:44
@marcaaron marcaaron self-assigned this May 5, 2022
@melvin-bot melvin-bot bot requested review from danieldoglas and removed request for a team May 5, 2022 18:44
Onyx.merge(ONYXKEYS.ACCOUNT, {success: true});
} else {
const error = lodashGet(response, 'message', 'Unable to login.');
Onyx.merge(ONYXKEYS.ACCOUNT, {error});
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aldo-expensify I'm just returning early now instead of setting the error again because it's already set here:

if (createLoginResponse.jsonCode !== 200) {
Onyx.merge(ONYXKEYS.ACCOUNT, {error: createLoginResponse.message});
return;
}

I think it's fine? The error message here is not translated anyway and doesn't provide much information so I think better to use the one from the server for now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine. The only remaining thing is to remove an unused import (lodash).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aldo-expensify
Copy link
Contributor

Added reproduction steps in QA steps.

Verified

This commit was signed with the committer’s verified signature.
marcaaron Marc Glasser
@marcaaron
Copy link
Contributor Author

Updated

@aldo-expensify
Copy link
Contributor

Looks like the linter is messed up. The line you are getting the warning is not that long:

Warning: 210:1 warning This line has a length of 208. Maximum allowed is 190 max-len

Line:

image

@marcaaron
Copy link
Contributor Author

Looks like the linter is messed up. The line you are getting the warning is not that long:

Very weird also not touching that file at all...

Copy link
Contributor

@danieldoglas danieldoglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to solve issue with lint.

@aldo-expensify aldo-expensify merged commit 724ccb4 into main May 6, 2022
@aldo-expensify aldo-expensify deleted the marcaaron-createLogin branch May 6, 2022 20:41
@melvin-bot melvin-bot bot added the Emergency label May 6, 2022
@melvin-bot
Copy link

melvin-bot bot commented May 6, 2022

@aldo-expensify looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@aldo-expensify
Copy link
Contributor

aldo-expensify commented May 6, 2022

Not an emergency: merged the PR without the linter passing because:

  • the warning was on a line on a file that was not being touched, and
  • the linter was warning about the length of line that was within the valid length.

In conclusion the linter was not making sense: #8886 (comment) and all the tests were passing

@OSBotify
Copy link
Contributor

OSBotify commented May 6, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @aldo-expensify in version: 1.1.58-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants