-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loads more chats fix #9002
Loads more chats fix #9002
Conversation
|
PR Reviewer Checklist
|
Web Screen.Recording.2022-05-14.at.2.48.37.AM.movDesktop Screen.Recording.2022-05-14.at.2.43.23.AM.movAndroid Screen.Recording.2022-05-14.at.2.45.39.AM.movIos Screen.Recording.2022-05-14.at.2.50.54.AM.mov |
Cool, merging to trigger the CP. I'll ask QA to re-test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and tests well!
@francoisl looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Not an emergency and travis tests were passing just fine. |
Loads more chats fix (cherry picked from commit 251df8b)
…9002 🍒 Cherry pick PR #9002 to staging 🍒
🚀 Cherry-picked to staging by @francoisl in version: 1.1.60-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by @AndrewGable in version: 1.1.60-3 🚀
|
Woops sorry thanks for catching @chiragsalian 🙇 |
Details
Fixed Issues
$ #8994
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
Mobile Web
Desktop
iOS
Android