Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - Chat - Download icon is not active for mp4 and mov files. #8943

Closed
kbecciv opened this issue May 11, 2022 · 3 comments · Fixed by #8952
Closed

mWeb - Chat - Download icon is not active for mp4 and mov files. #8943

kbecciv opened this issue May 11, 2022 · 3 comments · Fixed by #8952
Assignees

Comments

@kbecciv
Copy link

kbecciv commented May 11, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing PR: #8739

Action Performed:

  1. Go https://staging.new.expensify.com/
  2. Log in with any account
  3. Find the chat where you can download the mp4 file
  4. Hold the finger on file
  5. Tap download

Expected Result:

Download icon is active for mp4 and mov files.

Actual Result:

Describe what actually happened

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.57.12

Reproducible in staging?: Yes

Reproducible in production?: No (new feature)

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5567153_Screen_Recording_20220511-090053_Chrome__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 11, 2022

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@thienlnam
Copy link
Contributor

This appears to be happening on Web as well and not just isolated to mp4 and mov files. The structure of the html did not change and so this seems like it must be an issue with how we determine items are files

@thienlnam
Copy link
Contributor

Found the offending PR #8769

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants