Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GMT options from timezones #8712

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Remove GMT options from timezones #8712

merged 1 commit into from
Apr 21, 2022

Conversation

yuwenmemon
Copy link
Contributor

@yuwenmemon yuwenmemon commented Apr 21, 2022 •
edited
Loading

Pullearbearing (@sketchydroide)

Details

Remove the Etc/GMT timezones from the timezone options. See this comment for the explanation on why

Fixed Issues

$ #8251

Tests/QA

  1. Login to account “A”.
  2. Go to settings -> Profile
  3. Uncheck “Set my timezone automatically”
  4. Make sure there are no timezones available to select that start with "Etc/GMT"
  • Verify that no errors appear in the JS console

Screenshots

Screen Shot 2022-04-20 at 5 38 24 PM

@yuwenmemon yuwenmemon requested a review from a team as a code owner April 21, 2022 00:38
@yuwenmemon yuwenmemon self-assigned this Apr 21, 2022
@melvin-bot melvin-bot bot requested review from sketchydroide and removed request for a team April 21, 2022 00:39
@yuwenmemon yuwenmemon merged commit 8fda329 into main Apr 21, 2022
@yuwenmemon yuwenmemon deleted the yuwen-etc branch April 21, 2022 20:28
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@francoisl francoisl mentioned this pull request Apr 25, 2022
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @yuwenmemon in version: 1.1.57-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

This was referenced May 2, 2022
Closed
Closed
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sketchydroide sketchydroide sketchydroide approved these changes

Assignees

@yuwenmemon yuwenmemon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwenmemon @OSBotify @sketchydroide