-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update expensify-common #8743
Merged
Merged
update expensify-common #8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melvin-bot
bot
requested review from
roryabraham and
rushatgabhane
and removed request for
a team
April 21, 2022 22:47
90 tasks
rushatgabhane
approved these changes
Apr 21, 2022
@roryabraham PR approved |
@Expensify/applauseleads can we please make sure these QA steps are added to the regression suite in TestRail? |
roryabraham
approved these changes
Apr 22, 2022
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @roryabraham in version: 1.1.57-0 🚀
|
This was referenced May 2, 2022
🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀
|
This was referenced May 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
update expensify-common to include this fix in our app : Expensify/expensify-common#436
the main proposal for these 2 issues is here :
#7352 (comment)
#7644 (comment)
Fixed Issues
$ #7352
$ #7644
Tests
PR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
used the following test cases :-
1- copy normal text
hi this is test message
2- copy message containing number
123456
3- copy links
[link](www.google.com)
4- use code containing bold italic
5- copy some lines from GitHub here (open the file and copy)
App/src/components/TextInputFocusable/index.js
Lines 263 to 267 in 403fc28
6- copy some code from the code editor (VS code for example)
Screenshots
Web
copy multiple messages
https://user-images.githubusercontent.com/21364901/158659907-d8c1d90f-b641-4f10-af41-a51c5746811b.mov
copy from VScode
https://user-images.githubusercontent.com/21364901/158660512-af66417f-7c45-4b59-8264-4561e1fbc197.mov
copy from GitHub also works fine.
https://user-images.githubusercontent.com/21364901/158660921-9fff891f-be45-4cc8-94d3-8c9fd4aab0a1.mov
Mobile Web
Desktop
iOS
can't copy multiple messages
Android
can't copy multiple messages