Fix room creation error #8725

thesahindia · 2022-04-21T11:54:33Z

Details

Fixed the room creation error. We weren't correctly accessing the reportID.

Fixed Issues

$ #8534

Tests | QA Steps

Click on the green plus button in the bottom.
Choose new room
Enter room's name
Choose workspace
Click create room
Verify the room get's created and you get navigated to that room

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

Screenshots

Web

Screen.Recording.2022-04-21.at.4.44.44.PM.mov

Mobile Web

Screen.Recording.2022-04-21.at.4.48.55.PM.mov

Desktop

Screen.Recording.2022-04-21.at.4.59.08.PM.mov

iOS

Screen.Recording.2022-04-21.at.4.50.39.PM.mov

Android

Screen.Recording.2022-04-21.at.4.51.41.PM.mov

thesahindia · 2022-04-21T11:59:33Z

@marcaaron ignore the ping here. @AndrewGable, @rushatgabhane were supposed to be the reviewers here.

rushatgabhane

@thesahindia just some style comments

rushatgabhane · 2022-04-21T12:30:11Z

src/libs/actions/Report.js

@@ -1522,7 +1522,8 @@ function createPolicyRoom(policyID, reportName, visibility) {
            }
            return fetchChatReportsByIDs([response.reportID]);
        })
-        .then(([{reportID}]) => {
+        .then((response) => {
+            const {reportID} = _.values(response)[0];


Question: Is a response always guaranteed?

Avoid object destructuring for a single variable that you only use once. see style.md#destructuring

Use _.firstfor accessing the first element of the array.

Use lodashGet for accessing reportID, or we might crash the app.

I think this will meet all the conditions. It will set reportID as false if there's no response resulting in early return.
const reportID = lodashGet(_.first(_.values(chatReports)), 'reportID', false);

Sound good. Just make sure that the default value is an empty string instead of false.

Thanks

@rushatgabhane, done ✔️

src/libs/actions/Report.js

…x-room-error merge main

rushatgabhane

@AndrewGable Looks good and tests well!

#### PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

OSBotify · 2022-04-26T21:46:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-05-09T20:05:09Z

🚀 Cherry-picked to staging by @sketchydroide in version: 1.1.57-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2022-05-13T16:14:08Z

🚀 Deployed to production by @chiragsalian in version: 1.1.57-17 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

access reportID correctly

5822c33

thesahindia requested a review from marcaaron as a code owner April 21, 2022 11:54

rushatgabhane suggested changes Apr 21, 2022

View reviewed changes

marcaaron requested review from AndrewGable and removed request for marcaaron April 21, 2022 17:05

thesahindia added 2 commits April 25, 2022 23:09

Merge branch 'main' of github.com:thesahindia/App into thesahindia/fi…

b44e028

…x-room-error merge main

use lodashGet

c047096

rushatgabhane approved these changes Apr 26, 2022

View reviewed changes

AndrewGable approved these changes Apr 26, 2022

View reviewed changes

AndrewGable merged commit 7632516 into Expensify:main Apr 26, 2022

OSBotify mentioned this pull request May 10, 2022

Deploy Checklist: New Expensify 2022-04-25 #8777

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix room creation error #8725

Fix room creation error #8725

thesahindia commented Apr 21, 2022

thesahindia commented Apr 21, 2022

rushatgabhane left a comment

rushatgabhane Apr 21, 2022 •

edited

Loading

thesahindia Apr 21, 2022

rushatgabhane Apr 21, 2022 •

edited

Loading

thesahindia Apr 25, 2022

rushatgabhane left a comment •

edited

Loading

OSBotify commented Apr 26, 2022

OSBotify commented May 9, 2022

OSBotify commented May 13, 2022

Fix room creation error #8725

Fix room creation error #8725

Conversation

thesahindia commented Apr 21, 2022

Details

Fixed Issues

Tests | QA Steps

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web

Desktop

iOS

Android

thesahindia commented Apr 21, 2022

rushatgabhane left a comment

Choose a reason for hiding this comment

rushatgabhane Apr 21, 2022 • edited Loading

Choose a reason for hiding this comment

thesahindia Apr 21, 2022

Choose a reason for hiding this comment

rushatgabhane Apr 21, 2022 • edited Loading

Choose a reason for hiding this comment

thesahindia Apr 25, 2022

Choose a reason for hiding this comment

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

#### PR Reviewer Checklist

OSBotify commented Apr 26, 2022

OSBotify commented May 9, 2022

OSBotify commented May 13, 2022

rushatgabhane Apr 21, 2022 •

edited

Loading

rushatgabhane Apr 21, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading