[HOLD for payment 2022-05-20][$250] New room - Not able to create a new room, error message appears

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Log in to any expensifail account
2. Click on the green plus button in the bottom.
3. Choose new room
4. Enter room's name
5. Choose workspace
6. Click create room

Expected Result:

New room must be created when I click create room

Actual Result:

New room is not created and I see error message

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.52-0

Reproducible in staging?: y

Reproducible in production?: y

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

https://user-images.githubusercontent.com/43996225/162206860-40cf5b13-0f65-476c-b274-047d6fe1060a.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause @thesahindia

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648760293684219

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

Reproducible in production.
The API returns a 200 response for the CreatePolicyRoom call, so it's most likely a front-end issue interpreting the response.

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thesahindia]

I think that the backend must be sending the data in the form of an array earlier which was working just fine -

App/src/libs/actions/Report.js

Line 1526 in 0596be5

.then(([{reportID}]) => {

But now, you can see the logged response below (we're getting an object with key : report_SOME-ID)

I think we it should be fixed at the backend, but if for some reason we can't then I propose this fix -
We can make a variable for reportID and we just need to set the value after line 1523 (or we can just extract the key from the Object & use it)

App/src/libs/actions/Report.js

Lines 1518 to 1525 in 0596be5

	return API.CreatePolicyRoom({policyID, reportName, visibility})
	.then((response) => {
	if (response.jsonCode !== 200) {
	Growl.error(response.message);
	return;
	}
	return fetchChatReportsByIDs([response.reportID]);
	})

 Onyx.set(ONYXKEYS.IS_LOADING_CREATE_POLICY_ROOM, true);
+    let reportID;
    return API.CreatePolicyRoom({policyID, reportName, visibility})
        .then((response) => {
            if (response.jsonCode !== 200) {
                Growl.error(response.message);
                return;
            }
+            reportID = response.reportID;
            return fetchChatReportsByIDs([response.reportID]);
        })
        .then(() => {
            if (!reportID) {
                Log.error('Unable to grab policy room after creation', reportID);
                return;
            }

[jliexpensify]

Posted!

Internal - https://www.upwork.com/ab/applicants/1513707338062458880/job-details
External - https://www.upwork.com/jobs/~0149d3c7692c4cf31b

Invited @thesahindia as the bug reporter

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @AndrewGable (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

@thesahindia you found the cause. But I think we should fix it here by correctly accessing the reportID

App/src/libs/actions/Report.js

Line 1526 in 0596be5

.then(([{reportID}]) => {

Thoughts?

[rushatgabhane]

bump ^^ @thesahindia

[thesahindia]

@thesahindia you found the cause. But I think we should fix it here by correctly accessing the reportID

The object key keeps changing( reportID is not the key but the "report_" + value of reportID is ) so to do that we need to extract the key or the simple way would be to just use the reportID that we get in response here

App/src/libs/actions/Report.js

Lines 1518 to 1525 in 0596be5

	return API.CreatePolicyRoom({policyID, reportName, visibility})
	.then((response) => {
	if (response.jsonCode !== 200) {
	Growl.error(response.message);
	return;
	}
	return fetchChatReportsByIDs([response.reportID]);
	})

I had mentioned this here #8534 (comment)

[aneequeahmad]

PROPOSAL

We can extract the key from the response as below

        .then((response) => {
          const reportID = Object.values(response).map(({ reportID }) => reportID)[0]
            if (!reportID) {
                Log.error('Unable to grab policy room after creation', reportID);
                return;
            }
            

Instead of .then(([{reportID}]) => {

[rushatgabhane]

New contributors are limited to working on one job at a time, however experienced contributors may work on numerous jobs simultaneously. see contributing.md

@aneequeahmad since you're a new contributor, you're limited to only one job at a time. So I'd suggest that you complete the PR Expensify/expensify-common#441 as soon as possible. After which, you may work on multiple jobs. Thanks!

[rushatgabhane]

@thesahindia I'm sure we can figure something out using underscore.js. Please let me know when you submit an updated proposal, thanks!

[thesahindia]

Updated Proposal

We can use _.values to access the object

        .then((response) => {
            const {reportID} = _.values(response)[0];

[rushatgabhane]

@AndrewGable I like @thesahindia's proposal. Changes will be made over here -

App/src/libs/actions/Report.js

Lines 1526 to 1527 in 0596be5

	.then(([{reportID}]) => {
	if (!reportID) {

🎀 👀 🎀 C+ reviewed

[rushatgabhane]

@thesahindia a suggestion when posting an updated proposal -

• Please make sure it contains all the context. So there isn't a need to read the entire thread.

I hope this makes sense, thanks!

[melvin-bot]

📣 @thesahindia You have been assigned to this job by @AndrewGable!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[AndrewGable]

Looking forward to the PR 👍

[thesahindia]

PR is up.
cc: @AndrewGable, @rushatgabhane

[jliexpensify]

Not overdue Melv!

[jliexpensify]

Not overdue Melvin

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[jliexpensify]

Previous created job was closed, so re-created: https://www.upwork.com/ab/applicants/1528581043536789504/job-details

@rushatgabhane and @thesahindia - have re-invited you. Thanks!

[jliexpensify]

Paid @rushatgabhane , will pay $500 to @thesahindia once he accepts. Cheers!

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[thesahindia]

Accepted the offer, good to go 🚀

[jliexpensify]

Paid @thesahindia and closing this GH.