Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CheckboxWithLabel integration with Form #9065

Closed
luacmartins opened this issue May 18, 2022 · 4 comments
Closed

Fix CheckboxWithLabel integration with Form #9065

luacmartins opened this issue May 18, 2022 · 4 comments
Assignees
@luacmartins
Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@luacmartins
Copy link
Contributor

Problem

While refactoring AddDebitCard to use our Form component, I noticed that CheckboxWithLabel only works when the shouldSaveDraft prop is passed.

Why is this important

The component should work with Form so it can be used in our refactors

Solution

Make it work without passing shouldSaveDraft
@luacmartins luacmartins added Engineering Weekly KSv2 Improvement Item broken or needs improvement. labels May 18, 2022
@luacmartins luacmartins self-assigned this May 18, 2022
@melvin-bot melvin-bot bot added the Overdue label May 26, 2022
@luacmartins
Copy link
Contributor Author

I'm focused on the NewDot API issues, but will get to this next.

@melvin-bot melvin-bot bot removed the Overdue label May 26, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 3, 2022
@luacmartins
Copy link
Contributor Author

Focused on API refactors. Gonna try to get to this next week.

@melvin-bot melvin-bot bot removed the Overdue label Jun 3, 2022
@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2022
@luacmartins
Copy link
Contributor Author

Focused on API refactors. I'll try to get to this next week.

@melvin-bot melvin-bot bot removed the Overdue label Jun 13, 2022
@luacmartins luacmartins mentioned this issue Jun 16, 2022
Merged
89 tasks
@melvin-bot melvin-bot bot added the Overdue label Jun 21, 2022
@luacmartins
Copy link
Contributor Author

Have a draft PR up!

@melvin-bot melvin-bot bot removed the Overdue label Jun 22, 2022
@luacmartins luacmartins added the Reviewing Has a PR in review label Jun 23, 2022
@melvin-bot melvin-bot bot closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

Labels
Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@luacmartins