iPad - Login page is not appearing at the center and appears too close to top

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing #8752

Action Performed:

1. Launch the app
2. Verify that the login-form-layout is updated

Expected Result:

Login form layout is centered

Actual Result:

Log in page is located on the top of the header

Workaround:

Visual

Platform:

Where is this issue occurring?

• iOS - iPad safari and app

Version Number: 1.1.65.3
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[marcaaron]

Also seems related to #8752

[Santhosh-Sellavel]

@aneequeahmad Check this one!
This seems like a breakage but not sure why the new design changes didn't reflect here.

[Julesssss]

I asked here to confirm that we should expect to see the double panel layout on an iPad Pro

[aneequeahmad]

@Santhosh-Sellavel i didn't understand what use case is not handled. Could you please help me understand ?

[Julesssss]

@aneequeahmad there's a lot of comments to read through so I'm still a bit confused. The issue is that we're not seeing the original vertically stacked design on iPads. But please let me know if I misunderstood.

1. It sounds like the hardcoded cutoff had design approval (this comment)
2. But at the same time, the listed test case is failing

My guess is that all iPad sizes are too small to meet the hardcoded cutoff (or require an alternate solution) to show the vertically stacked component. So I think we'll need another fix so that iPad matches the original design.

iPad 12.9

[Julesssss]

Resolving the deployBlocker label as I submitted a hotfix which passed QA

[mvtglobally]

Issue not reproducible during KI retests. (First week) @Julesssss Can we close this?

[melvin-bot]

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@Julesssss Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Santhosh-Sellavel]

Melvin went mad I think!

[Santhosh-Sellavel]

By the way, I think we are good to close this now!

[thesahindia]

This issue is still reproducible

Screen.Recording.2022-06-02.at.11.51.58.PM.mov

cc: @Julesssss

[Julesssss]

Hey @thesahindia. Thanks for pointing this out, though I'm not 100% sure if we should fix this as this issue's error was just an iPad issue. The linked issue says it's just a tablet issue: #8122 (comment)

[thesahindia]

@Julesssss, should I report it on slack then?

[Julesssss]

Yeah, I think so. Let's treat it as a new issue to solve.