Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-05-20 #9111

Closed
14 tasks done
OSBotify opened this issue May 20, 2022 · 16 comments
Closed
14 tasks done

Deploy Checklist: New Expensify 2022-05-20 #9111

OSBotify opened this issue May 20, 2022 · 16 comments
Assignees
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented May 20, 2022

Release Version: 1.1.65-6
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label May 20, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.65-5 🚀

@mvtglobally
Copy link

Regression is complete
#8752 is failing due to #9121

@Julesssss Julesssss self-assigned this May 23, 2022
@Julesssss
Copy link
Contributor

Dealing with 9121 within the issue. It looks like an alternate solution is required for iPads.

@Julesssss
Copy link
Contributor

Raised a PR to fix 9121. It'll be CP'd shortly, once the iOS checks are passing

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.65-6 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.65-6 has been deployed to staging 🎉

@Julesssss
Copy link
Contributor

Nice. So 9121 should be fixed now.

@Julesssss
Copy link
Contributor

I also removed the deployBlocker label from 9122 as it looks like the issue already exists on production.

@Julesssss
Copy link
Contributor

Hey team, I can't remember if checking the deployBlocker box is my or your responsibility. Please uncheck them if I wasn't supposed to do that until they have been tested 😅

@Julesssss
Copy link
Contributor

@Expensify/applauseleads I need to sign off now, but I believe we're clear for testing the release again. Look forward to checking back in tomorrow morning 🤞

@isagoico
Copy link

Checking off #9101 (comment)

@melvin-bot melvin-bot bot added the Monthly KSv2 label May 23, 2022
@Julesssss Julesssss added Daily KSv2 and removed Monthly KSv2 labels May 24, 2022
@Julesssss
Copy link
Contributor

Just two issue awaiting QA now, hopeful that we can release today 🤞

@Julesssss
Copy link
Contributor

Checking off 8752 after a successful retest.

@Julesssss
Copy link
Contributor

Same for 9129 as it's a hotfix for the same PR.

I think that's all! Will be back soon to complete the deploy

@Julesssss
Copy link
Contributor

:shipit:

@SumitDiyora
Copy link

SumitDiyora commented May 26, 2022

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9080, #9107
Logged Issues - #8387, #8554, #8388, #8625

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants