Fix min hight constant typo #9129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyevans
approved these changes
May 23, 2022
|
@Julesssss can we do one more correction here. |
Oh great, what is it? |
|
Oh, you got that comment too, thanks! @Julesssss |
bondydaa
approved these changes
May 23, 2022
|
|
|
Nearly forgot theCherrypick label 😅 |
14 tasks
OSBotify
pushed a commit
that referenced
this pull request
May 23, 2022
Fix min hight constant typo (cherry picked from commit a0c8daf)
OSBotify
added a commit
that referenced
this pull request
May 23, 2022
…9129 🍒 Cherry pick PR #9129 to staging 🍒
|
🚀 Cherry-picked to staging by @amyevans in version: 1.1.65-6 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
|
Morning @Expensify/applauseleads, this one is ready for retesting now. Build |
|
Thanks, that looks good to me. Going to check it off. |
|
🚀 Deployed to production by @Julesssss in version: 1.1.65-6 🚀
|
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes a small issue with this PR
Fixed Issues
$ #9128
Tests
QA Steps
For ipad/tablets*
For other platforms
Verify that due to these changes [Payment due May 31] [$2000] iPad - Login form position should be a little lower in tablets - reported by @thesahindia #8122 (comment) is not effected for other platforms.
Screenshots
As this was a hotfix to this PR I only built to web and iPad (the platform which was broken)
Web
iOS