Deploy Checklist: New Expensify 2022-05-24

[OSBotify]

Release Version: 1.1.66-1
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Re-fetch actions when we move from offline to online in ReimbursementAccountPage.js #8831

  • QA
  • Accessibility

• Open old dot link with openOldDotLink() #8980

  • QA
  • Accessibility

• Prevent workspace menu from dismissing when clicking on add work email #9046

  • QA
  • Accessibility

• Deprecate API #9127

  • QA
  • Accessibility

• Fix min hight constant typo #9129

  • QA
  • Accessibility

• Simplify the isReady state for the sequential queue #9133

  • QA
  • Accessibility

• Remove unnecessary library for callback methods #9134

  • QA
  • Accessibility

• Adding generalists to code owners of lib directory #9136

  • QA
  • Accessibility

• Delay section display until ACH state has loaded #9138

  • QA
  • Accessibility

• Remove generalists from PR reviews for now #9146

  • QA
  • Accessibility

Deploy Blockers:

• Web - Chat - Clicking on the link https://staging.new.expensify.com/statement123 navigates to a blank screen within the app #9158
• Web -Workspace-Blank space appear for a brief moment after refreshing the page #9159
• Workspace -After connecting bank account the user can still see "Connect to bank" button #9161
• [$250] Web - Workspace - Added VBA does not show in any of the menu options when accessing offline #9166

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[mvtglobally]

@Julesssss , its been a while and IOS build still not available. Can you check if it is looking ok?

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.66-1 🚀

[mvtglobally]

@Julesssss Regression is completed

Deploy blockers logged
#9159
#9161
#9166

PR #8980 is failing due to #9158. Pls double check if it needs to be a blocker as experiences between PROD and Staging differs.
PR #9138 is failing due to #9159

Issues logged
#9157
#9158
#9162
#9164

[Julesssss]

Checked off 9159 which we believe should be expected after changes in other PRs.

[Julesssss]

Commented on 9161 as I have a feeling this is expected.

[Julesssss]

Additionally, I think 9166 has the same explanation as 9159 and is expected. But I'll await a second opinion before removing the label.

[mvtglobally]

@Julesssss, thanks for update. Hopefully we can have a new deploy today. Let us know if anything needs to be re-tested

[Julesssss]

After looking into 9158 it seems to be a regression, but this has been on prod for a few weeks now -- so is unrelated to this checklist. I've posted here and here to ensure we figure out a fix.

[Julesssss]

Checking of 9161 and 9166 and as discussed in the issues and in Slack.

[Julesssss]

Also checked off 9146 as there is no QA to be performed.

[Julesssss]

Checking off 9138 as the tests pass and we deemed the linked issue to not be a deployBlocker.

[Julesssss]

After looking into 9158 it seems to be a regression, but this has been on prod for a few weeks now -- so is unrelated to this checklist. I've posted here and here to ensure we figure out a fix.

Just to clarify. I was mistaken here. THIS is the PR which I believe introduced the issue so I've made it a deployBlocker.

[chiragsalian]

I'm checking off

• Web - Chat - Clicking on the link https://staging.new.expensify.com/statement123 navigates to a blank screen within the app #9158 since it looks like its resolved.
• Open old dot link with openOldDotLink() #8980 since it was only pending on comment from above.

[chiragsalian]

[SumitDiyora]

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9136, #9146
Logged Issues - #8403, #8401, #8400, #8413, #8402, #8388, #8387, #8579, #8624