Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Chat - Clicking on the link https://staging.new.expensify.com/statement123 navigates to a blank screen within the app #9158

Closed
kavimuru opened this issue May 24, 2022 · 14 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #8980

Action Performed:

  1. Launch the app.
  2. Open any report.
  3. Send this link - https://new.expensify.com/statements/123
    and click on the link
  4. Insert "staging" and click the link

Expected Result:

Verify that clicking on the link navigates the app to a screen within the app.

Actual Result:

Step3 : Opens in a new tab to login to NewDot production
Step4 : Blank screen within the app opens

Workaround:

Unknown

Platform:

Where is this issue occurring?
NOTE : Other than web in all other environments clicking https://.new.expensify.com/statements/123(https://new.expensify.com/statements/123) leads to blank page

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.66.0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5584486_Recording__23.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2022

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@TomatoToaster
Copy link
Contributor

Ah interesting. I'm going to try looking into this tomorrow because I have an idea of how the relinking is supposed to work, but if I can't figure this out by tomorrow, I'll make this external.

@rushatgabhane
Copy link
Member

Step 3 isn't a bug. new.expensify.com/statements/123 isn't supposed to work on staging.

@rushatgabhane
Copy link
Member

Step 4 isn't a bug because statements/123 doesn't exist.
We should def handle it in a better way tho

@Julesssss
Copy link
Contributor

Step 3 isn't a bug. new.expensify.com/statements/123 isn't supposed to work on staging.

I agree, but the next QA step resolves this:

  1. Insert "staging" ...

@Julesssss
Copy link
Contributor

Julesssss commented May 25, 2022

Step 4 isn't a bug because statements/123 doesn't exist. We should def handle it in a better way tho

I also agree with this. This issue sounds like new logic rather than a regression, right? Something like: 'handle links to statements that don't exist'

@rushatgabhane
Copy link
Member

This issue sounds like new logic rather than a regression, right? Something like: handle links to statements that don't exist

Yep, I agree!

@TomatoToaster
Copy link
Contributor

Oh neat! So should we repurpose this issue to be about better handling links to statements that don't exist or make a new one and close this?

@Julesssss Julesssss added DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 and removed Daily KSv2 labels May 25, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Julesssss
Copy link
Contributor

I'm making this a NewDot deploy blocker and it looks like it was introduced by this PR. It would be great if we could treat this with urgency as it remains the final blocker for the release.

Please remember to add the CP Staging label to the PR so that the fix is included in the release build. Thanks!

@thienlnam
Copy link
Contributor

I'm actually not sure if this is a deploy blocker anymore - it might just be a configuration issue on staging. I think we should retest this on production / and it should be fine since we're not using statements yet.

An additional add on would be to handle invalid dates in newDot (the page should just not load in oldDot)

@rushatgabhane
Copy link
Member

rushatgabhane commented May 25, 2022

Is it just me or I get the white screen on production too.

Some links that I've tried
https://new.expensify.com/statements/202102
https://new.expensify.com/statements/202205
https://new.expensify.com/statements/202204

Screen.Recording.2022-05-25.at.8.45.16.PM.mov

@thienlnam
Copy link
Contributor

Is it just me or I get the white screen on production too.

The white screen you're seeing is actually different from the error in the description. What email are you using to try to access those links? I think it's because you don't have access to a wallet.

Those links work for me on production besides https://new.expensify.com/statements/202205 since you can only view previous month statements

Screen Shot 2022-05-25 at 10 58 44 AM

@rushatgabhane
Copy link
Member

rushatgabhane commented May 25, 2022

I'm using my gmail account - rushatgabhane [at] gmail.com, and yes I don't have access to wallet.
That makes so much sense, thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants