-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Chat - Clicking on the link https://staging.new.expensify.com/statement123 navigates to a blank screen within the app #9158
Comments
Triggered auto assignment to @TomatoToaster ( |
Ah interesting. I'm going to try looking into this tomorrow because I have an idea of how the relinking is supposed to work, but if I can't figure this out by tomorrow, I'll make this external. |
Step 3 isn't a bug. |
Step 4 isn't a bug because |
I agree, but the next QA step resolves this:
|
I also agree with this. This issue sounds like new logic rather than a regression, right? Something like: 'handle links to statements that don't exist' |
Yep, I agree! |
Oh neat! So should we repurpose this issue to be about better handling links to statements that don't exist or make a new one and close this? |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
I'm making this a NewDot deploy blocker and it looks like it was introduced by this PR. It would be great if we could treat this with urgency as it remains the final blocker for the release. Please remember to add the |
I'm actually not sure if this is a deploy blocker anymore - it might just be a configuration issue on staging. I think we should retest this on production / and it should be fine since we're not using statements yet. An additional add on would be to handle invalid dates in newDot (the page should just not load in oldDot) |
Is it just me or I get the white screen on production too. Some links that I've tried Screen.Recording.2022-05-25.at.8.45.16.PM.mov |
The white screen you're seeing is actually different from the error in the description. What email are you using to try to access those links? I think it's because you don't have access to a wallet. Those links work for me on production besides https://new.expensify.com/statements/202205 since you can only view previous month statements |
I'm using my gmail account - rushatgabhane [at] gmail.com, and yes I don't have access to wallet. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue was found when executing #8980
Action Performed:
and click on the link
Expected Result:
Verify that clicking on the link navigates the app to a screen within the app.
Actual Result:
Step3 : Opens in a new tab to login to NewDot production
Step4 : Blank screen within the app opens
Workaround:
Unknown
Platform:
Where is this issue occurring?
NOTE : Other than web in all other environments clicking https://.new.expensify.com/statements/123(https://new.expensify.com/statements/123) leads to blank page
Version Number: 1.1.66.0
Reproducible in staging?: y
Reproducible in production?: y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5584486_Recording__23.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: