Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min hight constant typo #9129

Merged
merged 3 commits into from
May 23, 2022
Merged

Fix min hight constant typo #9129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c1d1bd
fix constant typo
Julesssss May 23, 2022
9e73a15
improve const comment
Julesssss May 23, 2022
92ea2d9
Merge branch 'main' into jules-fixMinHeightRegression
Julesssss May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/signin/SignInPageLayout/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ const SignInPageLayout = (props) => {
return content;
}

if (props.isMediumScreenWidth && props.windowHeight >= variables.minHeigthToShowGraphics) {
if (props.isMediumScreenWidth && props.windowHeight >= variables.minHeightToShowGraphics) {
return (
<View style={[styles.dFlex, styles.signInPageInner, styles.flexColumnReverse, styles.justifyContentBetween]}>
{graphicLayout}
Expand Down
2 changes: 1 addition & 1 deletion src/styles/variables.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,5 +46,5 @@ export default {
tooltipzIndex: 10050,
gutterWidth: 16,
popoverMenuShadow: '0px 4px 12px 0px rgba(0, 0, 0, 0.06)',
minHeightToShowGraphics: 854, // below this height UI was broken on login form layout as there isn't enough height to show forma and graphics.
minHeightToShowGraphics: 854, // Login form layout breaks below this height due to insufficient space to show the form and graphics
};