Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Attachment - Header of the attachment overlaps with device status icons in the preview of the attachment #9280

Closed
kavimuru opened this issue Jun 1, 2022 · 4 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jun 1, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to NewDot with any account
  2. Go to a chat or create one if needed
  3. Hit the "+" button at the bottom left of the chat input, then select "Add attachment" and upload a picture
  4. Wait for the attachment to finish uploading

Expected Result:

Header of attachment is not overlapping with phone icons

Actual Result:

Header of attachment is overlapping with phone icons

Workaround:

visual

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.70.2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers):
applausetester+0901abb@applause.expensifail.com / Feya87Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5593523_Screenshot_20220601-161517_New_Expensify

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jun 1, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Jun 1, 2022

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2022

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kavimuru kavimuru changed the title Android - Attachment - Header of the attachment overlaps with device panel in the preview of the attachment Android - Attachment - Header of the attachment overlaps with device status icons in the preview of the attachment Jun 1, 2022
@luacmartins
Copy link
Contributor

@alex-mechler
Copy link
Contributor

Confirmed #9210 is the PR that caused this, reverted it locally and the header was correct

@Tushu17 @mountiny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants