[HOLD for payment 2023-04-03] [$4000] Last message in the report shows for a brief moment when the keyboard opens while clicking on password text Input in password-protected pdf

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Sign in to NewExpensify Chrome on an Android or use Browserstack
2. Select a chat
3. Send a password protected pdf
4. Click on password protected pdf
5. Click on blue hyperlink to "enter password"
6. As the keyboard slides up, you can see briefly the chat behind.

You can continue to reproduce this just by tapping outside of the password input and then tapping on the input again, making the keyboard slide out and in again.

Expected Result

last chat should not show when keyboard opens

Actual Result

last chat flashes for a very brief moment when keyboard opens

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.75-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

WhatsApp.Video.2023-02-21.at.5.51.23.PM.mp4

az_recorder_20230222_153444.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1676983368278249

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b4d787358ad1fd5f
• Upwork Job ID: 1631047568284430336
• Last Price Increase: 2023-03-15

[MelvinBot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MelvinBot]

Triggered auto assignment to @ctkochan22 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Christinadobrzyn]

I'm not sure if this is something we want to fix now or put on hold as it's a pretty minor flicker and might be fixed with something else so going on right now (although I can't find any GHs that might relate). Adding Engineering label for a second opinion.

[ctkochan22]

@kavimuru

Can you confirm that this is only on android?

[Christinadobrzyn]

Not to step in, but I could only reproduce this on Android/Chrome.

I've tried downloading the Android Beta URL into BrowserStack, but I can't get it to work, so I'm unsure about Android/Native.

[ctkochan22]

@Christinadobrzyn could you do me a huge favor and get this re-assigned?

For next steps, I'd highly recommend seeing if this is an issue with the keyboard itself. And if there are other instances or past instances. It seems strange that it would happen here.

[MelvinBot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[aldo-expensify]

I reproduced this in Android native, didn't reproduce anywhere else.

hmmm, my theory: this is happening because the keyboard slides up taking some time, meanwhile, I'm guessing we adjust the pdf modal's height instantly, so there is a brief moment where there is a space between the pdf modal and the keyboard that is opening. This space allows you to see the screen behind, the chat.

I does look a bit weird, so I'll make it External in case a contributor finds an easy solution.

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~01b4d787358ad1fd5f

[MelvinBot]

Current assignee @Christinadobrzyn is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[MelvinBot]

Current assignee @aldo-expensify is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.89-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/15373 last message in the report shows for a brief moment #16332

If no regressions arise, payment will be issued on 2023-04-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif / @aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif / @aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif / @aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Christinadobrzyn] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/276386

[Christinadobrzyn]

Paid this out! Looks like a speed bonus applies

• @aimane-chnaif $4000 + 50% bonus for C+
• @tienifr $2000 + 50% bonus shared comp for fix
• @situchan $2000 + 50% bonus shared comp for fix
• @gadhiyamanan $250 as reporter

closed the job in upwork

@aimane-chnaif and @aldo-expensify can you give your thoughts on the test regression proposal here? Thanks!

[aldo-expensify]

@aimane-chnaif / @tienifr do you know which change introduced this bug exactly?

[parasharrajat]

It seems that this PR caused a regression https://expensify.slack.com/archives/C049HHMV9SM/p1680745076761309

[situchan]

It seems that this PR caused a regression https://expensify.slack.com/archives/C049HHMV9SM/p1680745076761309

Oh really? Didn't imagine our fix affected storybook.

I commented on that regression issue.

[parasharrajat]

I just saw it on slack so posted here. Please confirm this first.

[MelvinBot]

@Christinadobrzyn, @aldo-expensify, @aimane-chnaif, @situchan, @tienifr Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MelvinBot]

@Christinadobrzyn, @aldo-expensify, @aimane-chnaif, @situchan, @tienifr Whoops! This issue is 2 days overdue. Let's get this updated quick!

[situchan]

I confirmed that storybook issue existed before our PR so not a regression.
I would say #13580 is only the offending PR which caused regression.

[Christinadobrzyn]

Hi @situchan sorry I'm not quite sure where we are at this point, can you provide an update? Thanks!

[situchan]

Hi @situchan sorry I'm not quite sure where we are at this point, can you provide an update? Thanks!

We can go as normal. Our PR didn't cause any regression.
I think BZ checklist is just remaining and then close the issue.

[Christinadobrzyn]

Thanks @situchan!

@aldo-expensify and @aimane-chnaif are we happy with the test regression here - #15373 (comment)

[aimane-chnaif]

@Christinadobrzyn yes, I am happy

[Christinadobrzyn]

Regression test here - going to close this out!