Fix/15373 last message in the report shows for a brief moment #16332

tienifr · 2023-03-21T06:32:11Z

Details

Fixed Issues

$ #15373
$ #15373 (comment)

Tests

Sample password protected PDF: password-protected.pdf
Password: 1234

Sign in to NewExpensify Chrome on an Android
Select a chat
Send a password protected pdf
Click on password protected pdf
Click on blue hyperlink to "enter password"
As the keyboard slides up, verify that you will not see the chat behind.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Sample password protected PDF: password-protected.pdf
Password: 1234

Sign in to NewExpensify Chrome on an Android
Select a chat
Send a password protected pdf
Click on password protected pdf
Click on blue hyperlink to "enter password"
As the keyboard slides up, verify that you will not see the chat behind.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-03-21.at.12.53.59.mov

Mobile Web - Chrome

Screen.Recording.2023-03-21.at.12.52.14.mov

Mobile Web - Safari

Screen.Recording.2023-03-21.at.13.08.38.mov

Desktop

Screen.Recording.2023-03-21.at.13.00.35.mov

iOS

Screen.Recording.2023-03-21.at.13.07.16.mov

Android

Screen.Recording.2023-03-21.at.12.47.47.mov

…ginTop of the modal

MelvinBot · 2023-03-21T09:01:26Z

@aldo-expensify @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

situchan

@tienifr did you push all your changes? It's not complete yet.

src/styles/StyleUtils.js

src/libs/getSafeAreaPaddingTop/index.android.js

situchan · 2023-03-21T12:08:04Z

App/src/components/Modal/BaseModal.js

Line 142 in 3be4d99

} = StyleUtils.getSafeAreaPadding(insets);

-                       } = StyleUtils.getSafeAreaPadding(insets);
+                       } = StyleUtils.getSafeAreaPadding(insets, this.props.statusBarTranslucent);

situchan · 2023-03-21T12:09:52Z

@tienifr I think I gave all my feedback. Please check suggested changes.

tienifr · 2023-03-21T17:22:43Z

@situchan Thank you for suggesting. I have updated the code.
@aimane-chnaif @aldo-expensify After the PR is fully tested by @situchan, please help me review it!

situchan · 2023-03-21T17:29:19Z

I verified the JSDocs style guidelines (in STYLE.md) were followed

Let's follow jsdocs for new functions

src/styles/StyleUtils.js

aimane-chnaif · 2023-03-21T17:44:27Z

src/libs/getSafeAreaPaddingTop/index.android.js

@@ -0,0 +1,5 @@
+import {StatusBar} from 'react-native';
+
+export default function getSafeAreaPaddingTop(insets, statusBarTranslucent) {


As suggested by @situchan, add doc of description, params and return value.

Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>

tienifr · 2023-03-21T17:56:12Z

@situchan @aimane-chnaif updated, thanks for the feedback

situchan · 2023-03-21T18:24:59Z

bug.mp4

While testing, I noticed weird bugs on password protected pdf preview:

Loading forever sometimes (I think this is already reported). After close and open again, works
After click enter the password, password input modal briefly appears and disappears

Both are not constantly reproducible.
I confirmed that this also happens on main, not introduced by this PR.
Maybe regression from carousel PR.

situchan · 2023-03-21T19:00:30Z

Except the issue above, works well on all devices / platforms.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mp4

Mobile Web - Safari

msafari.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

android.mp4

tablet.mp4

situchan · 2023-03-21T19:34:53Z

After click enter the password, password input modal briefly appears and disappears

I reported this bug here

aimane-chnaif · 2023-03-21T19:39:05Z

ok, we can consider that bug out of scope for this issue.
cc: @aldo-expensify

aimane-chnaif · 2023-03-21T20:31:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mov

Mobile Web - Safari

msafari.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

android.mov

aimane-chnaif

Looks good and tests well on all kinds of modals.

tienifr · 2023-03-22T13:57:23Z

Hi @aldo-expensify We have the full test from @situchan and the approval of @aimane-chnaif. Please help me review the PR. Thank you!

aldo-expensify · 2023-03-22T17:38:45Z

Thanks, I'll review today

aldo-expensify

LGTM, tested well.

aldo-expensify · 2023-03-22T18:15:23Z

Thank you all for the collaborative work :)

OSBotify · 2023-03-22T18:22:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-24T19:06:35Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.2.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-27T10:33:17Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.89-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

remove statusBarTranslucent={false} and update the paddingTop and mar…

38932d5

…ginTop of the modal

tienifr marked this pull request as ready for review March 21, 2023 09:01

tienifr requested a review from a team as a code owner March 21, 2023 09:01

melvin-bot bot requested review from aimane-chnaif and aldo-expensify and removed request for a team March 21, 2023 09:01

tienifr mentioned this pull request Mar 21, 2023

[HOLD for payment 2023-04-03] [$4000] Last message in the report shows for a brief moment when the keyboard opens while clicking on password text Input in password-protected pdf #15373

Closed

6 tasks

situchan reviewed Mar 21, 2023

View reviewed changes

src/styles/StyleUtils.js Outdated Show resolved Hide resolved

situchan suggested changes Mar 21, 2023

View reviewed changes

src/styles/StyleUtils.js Outdated Show resolved Hide resolved

src/libs/getSafeAreaPaddingTop/index.android.js Outdated Show resolved Hide resolved

src/libs/getSafeAreaPaddingTop/index.android.js Outdated Show resolved Hide resolved

fix: add statusBarTranslucent

1ccd0b4

aimane-chnaif suggested changes Mar 21, 2023

View reviewed changes

tienifr and others added 2 commits March 22, 2023 00:48

fix: update src/styles/StyleUtils.js

8e84ce8

Co-authored-by: Aimane Chnaif <96077027+aimane-chnaif@users.noreply.github.com>

fix: add jsdocs definitions for the new functions

0befe08

aimane-chnaif approved these changes Mar 21, 2023

View reviewed changes

situchan approved these changes Mar 22, 2023

View reviewed changes

aldo-expensify approved these changes Mar 22, 2023

View reviewed changes

aldo-expensify merged commit 95d7990 into Expensify:main Mar 22, 2023

janicduplessis mentioned this pull request Mar 22, 2023

Make status bar transparent on android #15778

Merged

59 tasks

OSBotify mentioned this pull request Mar 24, 2023

Deploy Checklist: New Expensify 2023-03-24 #16489

Closed

44 tasks

situchan mentioned this pull request Apr 6, 2023

[HOLD for payment 2023-04-26] [$1000] Storybook - Errors appear in the JS console for Forms and PopoverMenu #17092

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/15373 last message in the report shows for a brief moment #16332

Fix/15373 last message in the report shows for a brief moment #16332

tienifr commented Mar 21, 2023 •

edited by aldo-expensify

Loading

MelvinBot commented Mar 21, 2023

situchan left a comment

situchan commented Mar 21, 2023

situchan commented Mar 21, 2023

tienifr commented Mar 21, 2023

situchan commented Mar 21, 2023

aimane-chnaif Mar 21, 2023

tienifr commented Mar 21, 2023

situchan commented Mar 21, 2023 •

edited

Loading

situchan commented Mar 21, 2023

situchan commented Mar 21, 2023

aimane-chnaif commented Mar 21, 2023

aimane-chnaif commented Mar 21, 2023

aimane-chnaif left a comment

tienifr commented Mar 22, 2023

aldo-expensify commented Mar 22, 2023

aldo-expensify left a comment

aldo-expensify commented Mar 22, 2023

OSBotify commented Mar 22, 2023

OSBotify commented Mar 24, 2023

OSBotify commented Mar 27, 2023

		@@ -0,0 +1,5 @@
		import {StatusBar} from 'react-native';

		export default function getSafeAreaPaddingTop(insets, statusBarTranslucent) {

Fix/15373 last message in the report shows for a brief moment #16332

Fix/15373 last message in the report shows for a brief moment #16332

Conversation

tienifr commented Mar 21, 2023 • edited by aldo-expensify Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 21, 2023

situchan left a comment

Choose a reason for hiding this comment

situchan commented Mar 21, 2023

situchan commented Mar 21, 2023

tienifr commented Mar 21, 2023

situchan commented Mar 21, 2023

aimane-chnaif Mar 21, 2023

Choose a reason for hiding this comment

tienifr commented Mar 21, 2023

situchan commented Mar 21, 2023 • edited Loading

situchan commented Mar 21, 2023

Screenshots/Videos

situchan commented Mar 21, 2023

aimane-chnaif commented Mar 21, 2023

aimane-chnaif commented Mar 21, 2023

Reviewer Checklist

Screenshots/Videos

aimane-chnaif left a comment

Choose a reason for hiding this comment

tienifr commented Mar 22, 2023

aldo-expensify commented Mar 22, 2023

aldo-expensify left a comment

Choose a reason for hiding this comment

aldo-expensify commented Mar 22, 2023

OSBotify commented Mar 22, 2023

OSBotify commented Mar 24, 2023

OSBotify commented Mar 27, 2023

tienifr commented Mar 21, 2023 •

edited by aldo-expensify

Loading

situchan commented Mar 21, 2023 •

edited

Loading