[$250] Implement Three Suggested Changes from Callstack

[Luke9389]

Background

Callstack is vendor that we've engaged to help with app performance. They've needed to delay our engagement until September, but in the mean time gave a few tips for us that they think would be helpful.

Suggested Changes

• The @react-native-community/cli dep shouldn't be added directly. It's a transitive dependency of react-native.
  Note: No longer adding @react-native-community/cli directly in package.json

• Both underscore and lodash are used. These are big libraries with the same purpose so you can pick one instead (we suggest lodash in this case)

• Remove Intl polyfills (@formatjs/intl*) usage, which can add up to 6MB of unicode data into the JS bundle. The Hermes version you're using supports Intl object by default, so polyfill is an unnecessary overhead

Game Plan

I'll bring these up for discussions with engineering to verify that we should proceed, and then implement the changes that we greenlight.

[Luke9389]

Brought this up in eng-chat here

[Luke9389]

After discussing this in the thread linked above, we've decided to strike number 2 from the list.

[Luke9389]

Coming back to this issue this week.

[Luke9389]

back soon

[parasharrajat]

One more thing that I can think of is to prevent the use of inline prop values(non-static) as much as possible.

1. No Inline callbacks.
2. No inline objects.

Object literals will recreate a new object on each render and due to a change of prop value, the underlying component will rerender.

[Luke9389]

Thanks @parasharrajat, I'll check out the impact of those suggestions 👍

[Luke9389]

Gonna loop back around to this

[Luke9389]

Hoping to get to this soon.

[Luke9389]

Hoping to get to this soon.

[Luke9389]

C+ would you be willing to help test this PR for me? #10750

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

[melvin-bot]

Current assignee @Luke9389 is eligible for the Exported assigner, not assigning anyone new.

[jboniface]

@mananjadhav job post here: https://www.upwork.com/jobs/~0175fa858fa8779088

[mananjadhav]

Applied @jboniface

[jboniface]

any update here? @Luke9389 / @mananjadhav

[mananjadhav]

I've reviewed and shared a bug with the PR. Waiting for the changes from @Luke9389. But mostly we need a RN upgrade from 0.69.0 to 0.70.0.

[Luke9389]

Hey @jboniface & @mananjadhav, I still haven't had a cycle to come back to this. I'll be updating soon.

[Luke9389]

I'm going to close this in favor of all the performance updates we're doing with margelo. I still haven't gotten the app to run without the format/intl dependency, and that's the only outstanding task from callstack of the original three.
@parasharrajat I think it's worth bringing this suggestion up in the open source room. That way we can make it a separate ticket if we decide to do it.

[Luke9389]

Thanks for helping test here @mananjadhav,
@Expensify/contributor-management would any of you be willing to pay out this issue for @mananjadhav?

[JmillsExpensify]

I'll do it. Assigning myself now.

[Luke9389]

Thanks!

[JmillsExpensify]

@mananjadhav Send you a contract offer here: https://www.upwork.com/jobs/~01967be1fa14712bf3

[JmillsExpensify]

Paid via Upwork

[JmillsExpensify]

Whoops. Closing since this is now paid!