[HOLD] [$250] Chat - "1 New message" badge does not display when user is on the older messages and a new message arrives

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Sign into account A on the main device . Sign into account B on another device
3. In account A, scroll to older messages with account B
4. Send some messages from account B to account A

Expected Result:

"1new message" badge appears in account A

Actual Result:

No badge appears even if the user A is somewhere in the top of the messages

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: v1.1.76-5
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+ihchat4@applause.expensifail.com / Yulia1986Gerets
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5608305_Recording__794.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[adelekennedy]

internal
external

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Triggered auto assignment to @marcochavezf (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[rushatgabhane]

@marcaaron @marcochavezf I don't remember exactly but we were closing any notification related issues right?

[marcaaron]

Yep, thanks @rushatgabhane (not closing but they are on hold for now)

[marcaaron]

We will look at open PRs when you are hired for a job. Guidelines here.

[aksoo5]

Proposal

The new message badge would not show if the receiving user was looking at an older message in the thread/report.
This was because the notification condition explicitly terminated the function before the badge code fired.
To solve the problem, the badge code has to be moved to precede that termination.

[GoEagles999]

Issue is related to FloatingMessageCounter. Scroll distance condition in toggleFloatingMessageCounter in ReportActionsView.js needs to be updated to allow for notifications to be shown when scroll offset is gt 200px.

[marcaaron]

Please propose solutions to issues that have the Help Wanted label, thanks.

[mvtglobally]

Issue not reproducible during KI retests. (First week)