Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-06-09 #9390

Closed
12 tasks done
OSBotify opened this issue Jun 9, 2022 · 6 comments
Closed
12 tasks done

Deploy Checklist: New Expensify 2022-06-09 #9390

OSBotify opened this issue Jun 9, 2022 · 6 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 9, 2022

Release Version: 1.1.76-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

@roryabraham
Copy link
Contributor

@Expensify/applauseleads 🍾 problems – we've got an empty checklist! I guess that's what happens when we do two deploys in a single day 😉 No need to lock it until we have at least one new PR.

In the meantime, a valuable thing to work on (if you're looking to fill your time) would be to review bug fixes over the last few months and evaluate if there are missing edge cases that should be added to the regression test suites.

@SumitDiyora
Copy link

SumitDiyora commented Jun 13, 2022

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9349 #9378, #9392, #9431
Logged Issues - #8465, #9463, #8430, #8398, #8393, #8392, #8577

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jun 13, 2022
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 13, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.76-5 🚀

@mvtglobally
Copy link

@roryabraham Regression is completed

Issues logged
#9391
#9403
#9406
#9407
#9436
#9437
#9438
#9439

@roryabraham
Copy link
Contributor

There's a new Android crash, but it's only happened once. I think it's probably a React Native bug, maybe only on Samsung devices (which seem to have a few issues with React Native TextInputs). It's pretty similar to this issue. For now, I think we can just try to monitor the crash and see if it keeps happening or if we can get some reproduction steps for the issue.

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Development

No branches or pull requests

5 participants