Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix analyze-packages script #9431

Merged
merged 1 commit into from
Jun 13, 2022
Merged

[No QA] Fix analyze-packages script #9431

merged 1 commit into from
Jun 13, 2022

Conversation

marcaaron
Copy link
Contributor

cc @Luke9389

Details

Script is broken this should fix it.

Fixed Issues

None

Tests

  1. run npm run analyze-packages verify the analyzer works

QA Steps

N/A

@marcaaron marcaaron self-assigned this Jun 13, 2022
@marcaaron marcaaron requested a review from a team as a code owner June 13, 2022 19:10
@melvin-bot
Copy link

melvin-bot bot commented Jun 13, 2022

npm has a package.json file and a package-lock.json file. It seems you updated one without the other, which is usually a sign of a mistake. If you are updating a package make sure that you update the version in package.json then run npm install

@melvin-bot melvin-bot bot requested review from robertjchen and removed request for a team June 13, 2022 19:10
Luke9389
Luke9389 approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@Luke9389 Luke9389 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marcaaron marcaaron merged commit 2d2c187 into main Jun 13, 2022
@marcaaron marcaaron deleted the marcaaron-fixAnalyzePackages branch June 13, 2022 19:29
@OSBotify OSBotify mentioned this pull request Jun 13, 2022
Closed
12 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @marcaaron in version: 1.1.76-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.76-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luke9389 Luke9389 Luke9389 approved these changes

@robertjchen robertjchen Awaiting requested review from robertjchen

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @Luke9389