Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] VBA - Each of the Workspace option setting is showing locked after refresh #9535

Closed
kbecciv opened this issue Jun 22, 2022 · 16 comments
Closed
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jun 22, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing: #9490

Action Performed:

  1. Go to staging.new.expensify.com and go to settings
  2. Enable Staging Setting
  3. Go to any Workspace and click Connect bank account
  4. Select Connect by Plaid and add the Bank account
  5. Go to Setting - Payments
  6. Verify the Bank account is displayed
  7. Go to OldDot with the same account
  8. Go to Setting - Account - Payments
  9. Delete the VBA
  10. Go to New Expensify app
  11. Tap on Setting - Workspace
  12. Check each of the Workspace option settings

Expected Result:

Each of the Workspace option setting is showing locked after delete the VBA from OldDot

Actual Result:

Each of the Workspace option setting is showing locked after refresh.

Workaround:

Unknown

Additional Information:

Also after deleted the VBA from the Payment option page - VBA is still present

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.78.7

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.632.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2022

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alex-mechler
Copy link
Contributor

For the first video, going outside of NewDot, making a change in OldDot, and having not reflect in NewDot without a refresh is a pretty edge case flow that we aren't looking to solve at this time. Going to remove it from the main issue to prevent confusion

The second video does seem like something we need to fix, since we should not be showing it on that list after we have selected delete. Should be solvable externally.

@alex-mechler alex-mechler removed their assignment Jun 22, 2022
@alex-mechler alex-mechler added the External Added to denote the issue can be worked on by a contributor label Jun 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2022

Triggered auto assignment to @arielgreen (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@arielgreen
Copy link
Contributor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jun 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2022

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (Exported)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2022

Triggered auto assignment to @stitesExpensify (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot changed the title VBA - Each of the Workspace option setting is showing locked after refresh [$250] VBA - Each of the Workspace option setting is showing locked after refresh Jun 22, 2022
@kaushiktd
Copy link
Contributor

For that when you have removed your bank account then maybe props is not getting
refreshed so it is showing still locked. We need to find whether the redux props value is getting
updated or not.

@Santhosh-Sellavel
Copy link
Collaborator

@kaushiktd Can you make a proposal to solve this issue? Look at examples here for how to make a proposal.

But before that make sure you read our contributing guidelines first to understand our process!

@kaushiktd
Copy link
Contributor

@Santhosh-Sellavel Can you please explain what you mean by making a proposal? I checked that examples link which shows a list of HOLD FOR PAYMENT tasks. If you can guide me, will be very helpful.

@Santhosh-Sellavel
Copy link
Collaborator

@kaushiktd Yes those are closed issues that are worked by external contributors. Go through a few of those issues and look for comments with the word Proposal at the start of the comment, you can get to know about how to write a proposal.

@kaushiktd
Copy link
Contributor

@Santhosh-Sellavel When we are adding a new bank detail, Plaid is redirected to Bank sever to authenticate, and we don't have any bank account listed in the Plaid account list.
We can't check it with test credentials because the backend API is returning the production server token, so it is not working.

Without adding any bank account we can't find why it is locked after even being removed. Is there anyway I can add the bank?

See the recording: https://drive.google.com/file/d/1FD0b3I5K1keqX0SbVil4kEFE7mkuOWo8/view?usp=sharing

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Jul 1, 2022
@arielgreen
Copy link
Contributor

let's give it another week before closing

@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2022
@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@melvin-bot melvin-bot bot added the Overdue label Jul 11, 2022
@stitesExpensify
Copy link
Contributor

When do we usually close issues? This is the third week right?

@melvin-bot melvin-bot bot removed the Overdue label Jul 11, 2022
@arielgreen
Copy link
Contributor

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants