Deploy Checklist: New Expensify 2022-06-16

[OSBotify]

Release Version: 1.1.78-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Add a button to expand the composer to full screen when the input has 3+ lines #9031

  • QA
  • Accessibility

• Download icon isn't turning green when clicking to download #9266

  • QA
  • Accessibility

• Fix: Remove button isn't disabled when a user is removed by pressing Enter #9347

  • QA
  • Accessibility

• Fix crash issue on account create android #9401

  • QA
  • Accessibility

• Fix Issue #9307: Update ScrollView by View, wrapper of OptionsList in IOUConfirmationList #9404

  • QA
  • Accessibility

• Stop double-submit of set password form #9445

  • QA
  • Accessibility

• Do not append & to internal Expenisfy URLs that have a # symbol. #9450

  • QA
  • Accessibility

• Add exception for default rooms beta for users who are members of a free policy #9460

  • QA
  • Accessibility

• Stop listening to chunked events now that they are not sent #9462

  • QA
  • Accessibility

• [No QA] Remove @react-native-community/cli Dependency #9468

  • QA
  • Accessibility

• Update package.json to reflect update in expensify-common to make https as default application protocol #9471

  • QA
  • Accessibility

• Remove selected duplicate contacts from Recents #9472

  • QA
  • Accessibility

• Fix Issue #9413: On using arrow keys, Both emoji picker and Chat history is scrolling simultaneously #9473

  • QA
  • Accessibility

• Fix file mapping in dev #9475

  • QA
  • Accessibility

• Remove inconsistent margin from ReportAction when offline #9482

  • QA
  • Accessibility

• fix keyboard type #9486

  • QA
  • Accessibility

• [No QA] Create a readme for API details #9488

  • QA
  • Accessibility

• fix: Lock workspace settings after Delete #9490

  • QA
  • Accessibility

• Resolve tooltip clipped issue #9492

  • QA
  • Accessibility

• Update fastlane to the latest version #9496

  • QA
  • Accessibility

• Support for copy link option #9502

  • QA
  • Accessibility

• Fix regex in getStagingDeployCashInternalQA #9523

  • QA
  • Accessibility

Internal QA:

• Fix the InternalQA checklist loosing its state #9458 - @yuwenmemon @mountiny

Deploy Blockers:

• [PAY RUSHAT 14TH JUL] Search - App crashed after click on Search option for specific account #9487
• Android - API error displayed after create a new public account  #9564
• TEST - Testing Deploy Checklist #9565

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.78-0 🚀

[mvtglobally]

@francoisl Android build is still not updated. We are just waiting for the Android to finish up this checklist

[francoisl]

@francoisl Android build is still not updated. We are just waiting for the Android to finish up this checklist

Yep thanks, we're looking into this. I'll let you know when we have an update.

---

Also, I'm checking 9487 from the blockers list based on this comment.

[francoisl]

We might have to wait a few more days for the new Android build.

For context, Google rejected the app saying that it didn't respect their Payments policy because we don't use Google Play's billing system. We believe they made a mistake, because their policy mandates that apps that use peer-to-peer payments should not use their billing system. We filed an appeal and are waiting to hear back from them.

[SumitDiyora]

Checked all PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9266, #9401, #9404, #9445, #9460, #9462, #9468, #9473
Logged Issues - #8432 , #9491 #8434 #8433 #8413 #8651 #8430 #8388 #8465 #8392 #8395 #8560 #8393 #8398 #8484 #8623 #8506 #9463 #8577

New PRs Added
Checked all new PRs on Production / Staging and created accessibility issues for all PRs where accessibility issues were found.
The non-applicable PRs are - #9450, #9458, #9471, #9482, #9475, #9490, #9488, #9502, #9523
Logged Issues - #8430, #8393, #8465, #8392, #8395, #8398, #8506, #9463, #8616, #8463, #8484, #8407, #8465, #8392, #8393, #8398, #8385, #9557, #8395, #8556, #8430, #8580, #8463, #8651, #8393, #8484, #9571

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.78-7 🚀

[francoisl]

@Expensify/applauseleads there should be a new build 1.1.78-8 rolling out - including on Android this time. Can you please resume QA from that version?

[sketchydroide]

#9487 and #9564 no longer seem to be Deploy blockers and #9565 is closed and dusted
I would say once this latest build is QA we can ship this.

@Expensify/applauseleads can we excpect the QA to be done today?

[mvtglobally]

@sketchydroide, Regression is completed. I am sending a summary in few min

[mvtglobally]

@sketchydroide @francoisl , Regression is completed.

PR #9031 is failing due to #9438. Not a blocker, so checking off
PR #9401 & PR #9445 are blocked by #9564. Blocker label was removed. are we ok to check it off then?
PR #9471 is failing due to #9533 Not a blocker, are we ok to check off?
PR #9490 is failing due to #9490. Not a blocker checking off
PR ##9496 is internal. Can you double check its ok to check it off?

Issues logged
#9485
#9487
#9533
#9535
#9539
#9541
#9542
#9564

[francoisl]

PR #9401 & PR #9445 are blocked by #9564. Blocker label was removed. are we ok to check it off then?

Yes since there's also a similar issue with the production build. We'll reopen the GH issue to look into this. (cc @aldo-expensify @TomatoToaster)

[francoisl]

PR #9471 is failing due to #9533 Not a blocker, are we ok to check off?

Double-checking now, but at first glance it looks like this wouldn't be a blocker indeed and we should be able to check it off.

PR #9490 is failing due to #9490. Not a blocker checking off

👍

PR ##9496 is internal. Can you double check its ok to check it off?

Yes this was a fix for iOS deploys not working, it's confirmed to work by the fact that we could CP and generate an iOS build.

[mvtglobally]

Great, Looks like we are good to 🚀

[sketchydroide]

thanks @francoisl for going over those, I agree, I think those are not blockers

[sketchydroide]

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[OSBotify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[sketchydroide]