-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fastlane to the latest version #9496
Conversation
|
5262e85
to
b1276af
Compare
Nevermind, using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better! 👍
Update fastlane to the latest version (cherry picked from commit 96fcc8b)
…9496 🍒 Cherry pick PR #9496 to staging 🍒
🚀 Cherry-picked to staging by @Beamanator in version: 1.1.78-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Cherry-picked to staging by @Beamanator in version: 1.1.78-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Details
This change updates fastlane to its latest version,
2.206.2
, in hopes that it resolves theAuthentication credentials are missing or invalid. - Provide a properly configured and signed bearer token, and make sure that it has not expired.
issues we've been seeing with iOS deploys (example).Fixed Issues
N/A, discussed in Slack here.
Tests
I launched the app on the iOS simulator, then tested the main use cases to make sure there were no warnings or crashes.
PR Review Checklist
Contributor (PR Author) Checklist
I linked the correct issue in the### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followed/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Internal QA - we'll monitor the staging deploy and make sure that it deploys correctly to iOS.
Screenshots
Web
Mobile Web
Desktop
iOS
Android