Fix Issue #9413: On using arrow keys, Both emoji picker and Chat history is scrolling simultaneously #9473

JosueEchandiaAsto · 2022-06-16T16:01:21Z

Details

Error: Both emoji picker and Chat history is scrolling simultaneously.
Solution:
When the keyBoardEvent on the EmojiPickerMenu catches an 'Arrow' event, preventDefault(); needs to be called.

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 136 to 140 in 0d6850a

    
           this.keyDownHandler = (keyBoardEvent) => { 
        
               if (keyBoardEvent.key.startsWith('Arrow')) { 
        
                   // Move the highlight when arrow keys are pressed 
        
                   this.highlightAdjacentEmoji(keyBoardEvent.key); 
        
                   return;

Adding preventDefault();

App/src/components/EmojiPicker/EmojiPickerMenu/index.js

Lines 136 to 142 in e98cf8e

    
           this.keyDownHandler = (keyBoardEvent) => { 
        
               if (keyBoardEvent.key.startsWith('Arrow')) { 
        
                   keyBoardEvent.preventDefault(); 
        
                   // Move the highlight when arrow keys are pressed 
        
                   this.highlightAdjacentEmoji(keyBoardEvent.key); 
        
                   return;

Fixed Issues

#9413

Tests

Verify that only scroll the emoji picker (not Chat history) when press Down and Up key on keyboard.
Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Go to Chat > Send a Message > Edit Message
Open Emoji picker in edit message, then press Down and Up key on keyboard.
Verify that only scroll the emoji picker (not Chat history) when press Down and Up key on keyboard.
Verify that no errors appear in the JS console

Screenshots

Web

Safari

Grabacion.de.pantalla.2022-06-15.a.la.s.12.14.42.mov

Chrome

Grabacion.de.pantalla.2022-06-16.a.la.s.10.40.56.mov

Firefox

Grabacion.de.pantalla.2022-06-16.a.la.s.10.42.18.mov

Mobile Web

iOS/Safari

Simulator.Screen.Recording.-.iPhone.13.-.2022-06-16.at.10.54.30.mp4

Desktop

Grabacion.de.pantalla.2022-06-16.a.la.s.10.58.37.mov

iOS

Simulator.Screen.Recording.-.iPhone.13.-.2022-06-16.at.10.56.40.mp4

Android

Grabacion.de.pantalla.2022-06-16.a.la.s.10.53.28.mov

rushatgabhane

@luacmartins Tests well and LGTM! 🎉
@JosueEchandiaAsto I really appreciate you adding screen recordings for all browsers!! 🙌

PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.

rushatgabhane · 2022-06-16T17:48:25Z

@JosueEchandiaAsto can you please number your steps. (checkboxes seem weird 😅)

Go to Chat > Send a Message > Edit Message
Open Emoji picker in edit message, then press Down and Up key on keyboard.
Verify that only scroll the emoji picker (not Chat history) when press Down and Up key on keyboard.

JosueEchandiaAsto · 2022-06-16T17:59:02Z

@rushatgabhane, Done. I changed the checkboxes by steps 🙌

luacmartins

LGTM!

OSBotify · 2022-06-16T18:10:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-06-16T22:06:46Z

🚀 Deployed to staging by @luacmartins in version: 1.1.78-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-06-28T10:06:54Z

🚀 Deployed to production by @sketchydroide in version: 1.1.78-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat · 2022-08-05T05:15:20Z

There is a regression from this PR #10182

luacmartins · 2022-08-08T15:10:51Z

Thanks for pointing that out @parasharrajat!

Proposal Issue 9413

e98cf8e

JosueEchandiaAsto requested a review from a team as a code owner June 16, 2022 16:01

melvin-bot bot requested review from luacmartins and rushatgabhane and removed request for a team June 16, 2022 16:01

rushatgabhane approved these changes Jun 16, 2022

View reviewed changes

luacmartins approved these changes Jun 16, 2022

View reviewed changes

luacmartins merged commit bfd579a into Expensify:main Jun 16, 2022

OSBotify mentioned this pull request Jun 16, 2022

Deploy Checklist: New Expensify 2022-06-16 #9480

Closed

50 tasks

luacmartins mentioned this pull request Jun 23, 2022

Desktop - Keyboard arrow keys doesn't work on New chat/Send money/Request money flow @Tushu17 #9517

Closed

neil-marcellini mentioned this pull request Aug 4, 2022

[HOLD for payment 2022-08-30] [$250] Unable to move cursor (left/right) in searchbar - Reported by @daraksha-dk #10182

Closed

vladnyk mentioned this pull request Aug 9, 2022

fix "Unable to move cursor (left/right) in searchbar" #10304

Merged

93 tasks

rushatgabhane mentioned this pull request Aug 11, 2022

[HOLD for payment 2022-08-11] [$250] Web - Moving to and from search bar to bottom emoji is inconsistent @daraksha-dk #9728

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Issue #9413: On using arrow keys, Both emoji picker and Chat history is scrolling simultaneously #9473

Fix Issue #9413: On using arrow keys, Both emoji picker and Chat history is scrolling simultaneously #9473

JosueEchandiaAsto commented Jun 16, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Jun 16, 2022 •

edited

Loading

JosueEchandiaAsto commented Jun 16, 2022

luacmartins left a comment

OSBotify commented Jun 16, 2022

OSBotify commented Jun 16, 2022

OSBotify commented Jun 28, 2022

parasharrajat commented Aug 5, 2022 •

edited

Loading

luacmartins commented Aug 8, 2022

	this.keyDownHandler = (keyBoardEvent) => {
	if (keyBoardEvent.key.startsWith('Arrow')) {
	// Move the highlight when arrow keys are pressed
	this.highlightAdjacentEmoji(keyBoardEvent.key);
	return;

	this.keyDownHandler = (keyBoardEvent) => {
	if (keyBoardEvent.key.startsWith('Arrow')) {
	keyBoardEvent.preventDefault();

	// Move the highlight when arrow keys are pressed
	this.highlightAdjacentEmoji(keyBoardEvent.key);
	return;

Fix Issue #9413: On using arrow keys, Both emoji picker and Chat history is scrolling simultaneously #9473

Fix Issue #9413: On using arrow keys, Both emoji picker and Chat history is scrolling simultaneously #9473

Conversation

JosueEchandiaAsto commented Jun 16, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

rushatgabhane commented Jun 16, 2022 • edited Loading

JosueEchandiaAsto commented Jun 16, 2022

luacmartins left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 16, 2022

OSBotify commented Jun 16, 2022

OSBotify commented Jun 28, 2022

parasharrajat commented Aug 5, 2022 • edited Loading

luacmartins commented Aug 8, 2022

JosueEchandiaAsto commented Jun 16, 2022 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Jun 16, 2022 •

edited

Loading

parasharrajat commented Aug 5, 2022 •

edited

Loading