[HOLD for payment 2022-08-11] [$250] Web - Moving to and from search bar to bottom emoji is inconsistent @daraksha-dk

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com and log in
2. Go to any chat > click on emoji picker > press down arrow key
3. Nothing is selected
4. Same thing with up arrow, if you're under "Frequently Used", it will not go to Search on first click

Expected Result:

It should move to the correct location in one click

Actual Result:

Need to click up or down two times instead of one

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.79.17

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.727.mp4

Expensify/Expensify Issue URL:

Issue reported by: @daraksha-dk

Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1654366872160559

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @arielgreen (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[kbecciv]

Similar issue #9413

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[danieldoglas]

Applying External, but I will also apply the monthly priority since it isn't something that is breaking behavior.

[melvin-bot]

Triggered auto assignment to @puneetlath (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[danieldoglas]

Also, this and #9413 are report different behaviors so I think we won't solve both together.

[puneetlath]

Hmm, @danieldoglas I think it actually makes sense to keep them separate since that issue is just about the scrolling. So I'm going to go ahead and create a job for this one. Let me know if you disagree!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (Exported)

[melvin-bot]

Current assignee @puneetlath is eligible for the Exported assigner, not assigning anyone new.

[puneetlath]

Upwork job is here: https://www.upwork.com/jobs/~01c019031511555a58

[eVoloshchak]

Can you apply to the Upwork job as well so I can hire you there? Thanks!

Applied on the Upwork
PR is up.
I also found more reliable and simple way to fix this issue, details are in the PR description.

[puneetlath]

Thanks. Hired and merged.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.87-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix issue with keyboard navigation in emoji picker #9954

If no regressions arise, payment will be issued on 2022-08-11. 🎊

[neil-marcellini]

There has been a regression. Please see the related issue.

[eVoloshchak]

#10223 was present before this PR, I'm not sure this is a regression
I reverted #9954, you can still see the #10223

cinnamon-20220805-6.1.mp4

[neil-marcellini]

#10223 is not the regression. #10182 is the regression.

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[parasharrajat]

Is this a duplicate of #8459?

[melvin-bot]

⚠️ Looks like this issue was linked to a possible regression on PRODUCTION here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a production regression has occurred a Root Cause Analysis is required. Please follow the instructions here.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[rushatgabhane]

Is this a duplicate of #8459?

@parasharrajat i don't think so. This issue is related to an extra arrow key press required to move from search and emoji

[parasharrajat]

Thanks for the details.

[puneetlath]

Is #10223 related to this? I'm guessing not since it happens on both staging and production.

[rushatgabhane]

@puneetlath I reverted #9954

But the issue was still present. #10223 isn't related

[puneetlath]

Paid @eVoloshchak and @daraksha-dk.

Sent C+ offer to @rushatgabhane.

[rushatgabhane]

@puneetlath I received an offer for half pay, but the PR for this issue didn't cause any regression.

The regression is related to another PR.

(Verification - #10182 (comment))

[puneetlath]

Ah got it, my bad! Updated the offer.

[puneetlath]

Everyone has been paid. Thanks for your contributions!