[$250] Web - Attachment - Attachment tag displayed in LHN after refresh

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with any account
3. Go to any user and click on Plus button
4. Attach any jpg file
5. Click Send button
6. Check the Attachment tag under LHN
7. Refresh the page

Expected Result:

Attachment tag displayed in LHN after sent the file

Actual Result:

User's email address is displayed

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.78.7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+0901abb@applause.expensifail.com / Feya87Katya
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5619702_Bug5612401_Recording__603.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause internal team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MitchExpensify]

Upwork Issue

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (Exported)

[melvin-bot]

Current assignee @roryabraham is eligible for the Exported assigner, not assigning anyone new.

[JosueEchandiaAsto]

Proposal

Issue

User's email address is displayed after sent the file

Fix

After uploading the attached file, it is updating lastMessageText, ignoring that it is an attached file, that is why the text is wrong.

App/src/libs/actions/Report.js

Line 554 in 3757142

const messageText = parser.htmlToText(messageHtml);

We need to add the missing logic so that when it is an attachment it updates the text correctly.

App/src/libs/actions/Report.js

Line 555 in 1761614

const messageText = isAttachment ? `[${Localize.translateLocal('common.attachment')}]` : parser.htmlToText(messageHtml);

Commit: 1761614

Result

Grabacion.de.pantalla.2022-06-24.a.la.s.08.21.53.mov

[mananjadhav]

I thought this was a regression and I tried finding the root cause. It seems this happens to the current chat when the attachment is added. If we refresh then it shows up properly.

@roryabraham, @JosueEchandiaAsto's proposal looks good.

🎀 👀 🎀
C+ reviewed

[roryabraham]

Okay, LGTM 👍

Long-term, I would like to see some unit tests added for the title and subtitle of items in the LHN.

[melvin-bot]

📣 @JosueEchandiaAsto You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[MitchExpensify]

Nice! Invited both @JosueEchandiaAsto & @mananjadhav to the Upwork job for eventual payment.

[JosueEchandiaAsto]

PR Created 🎉 #9603

[marcaaron]

This issue will need to be fixed on the server as the method where the fix is happening is getting removed. Let's avoid doing duplicate work here and maybe close this one out or make it internal and HOLD on changes here -> #9350

[roryabraham]

Okay, my mistake. Going to put this on HOLD pending #9350. @MitchExpensify Can we please pay out @JosueEchandiaAsto for their work so far?

[MitchExpensify]

Will do! @JosueEchandiaAsto just waiting for the offer to be accepted

[mananjadhav]

@roryabraham @MitchExpensify Is this eligible for C+ payout?

[JosueEchandiaAsto]

@MitchExpensify, Offer accepted 👨🏻‍💻

[MitchExpensify]

Thanks! Paid

[MitchExpensify]

Are we good to close this out then?

[mananjadhav]

@roryabraham @MitchExpensify Is this eligible for C+ payout?

@MitchExpensify bump

[MitchExpensify]

Thanks for the bump @mananjadhav ! We're chatting internally and will have an update very soon

[MitchExpensify]

Paid @mananjadhav, thanks so much for your patience!