-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] Move No QA PRs to a separate section of the checklist #9905
Comments
Going to HOLD this on #9999 |
Might be good to do alongside, although quite scared of the refactor there, definitely a stuff to work on after the Offshore 😄 |
Working on higher level priorities still |
Since the PR we hodl this on was closed as low priority, do you think we should still do this? I think it is nice to have but also it is easy for QA to just check it off the first time they see the check list. I will close this for now and if we will come back to polishing the deploy checklist experience and refactor, we should look into this. @roryabraham reopen if you disagree. |
Problem
Sometimes our deploy checklists get very large. When there are many documentation, helpsite, or GitHub Actions PRs in the checklist, those PRs typically don't need any QA.
As a time-saver/QOL improvement for Applause and deployers, we automatically check off any PR on the checklist if the title is prefixed with
[No QA]
.However, in some cases such as this one, there are a ton of
[No QA]
PRs. This makes life more difficult for Applause and for the deployer, because they have to sift through many distracting checklist items to find the ones that they actually tested.According to @isagoico:
I've also experienced this problem in a different way – as a deployer I want to quickly be able to see any PRs that aren't resolved yet and which may be blocking deploy. When normal PRs are mixed in with a large list of PRs that didn't undergo QA, it takes longer.
Solution
Move
[No QA]
PRs to a separate section of the checklist, where they don't actually get checkboxes and instead are just listed out for audit/record-keeping/diff purposes.The text was updated successfully, but these errors were encountered: