Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-07-12 #9847

Closed
72 of 95 tasks
OSBotify opened this issue Jul 12, 2022 · 22 comments
Closed
72 of 95 tasks

Deploy Checklist: New Expensify 2022-07-12 #9847

OSBotify opened this issue Jul 12, 2022 · 22 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jul 12, 2022 •
edited by chiragsalian
Loading

Release Version: 1.1.84-13
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes.

cc @Expensify/applauseleads
@roryabraham roryabraham mentioned this issue Jul 12, 2022
Closed
@roryabraham
Copy link
Contributor

@Expensify/applauseleads Please keep this unlocked while I break some more stuff 🙇

@mvtglobally mvtglobally added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Jul 12, 2022
@mvtglobally
Copy link

@roryabraham :) tag us whenever we are ready to rock n roll

@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.84-1 🚀

@mvtglobally
Copy link

@roryabraham are we ok to start QA or you still checking build

@roryabraham
Copy link
Contributor

As promised, I broke stuff while making deploy code changes. Things are still broken unfortunately, but I'm actively working on a fix.

@roryabraham
Copy link
Contributor

Apologies. I'm breaking stuff now to (hopefully) make things faster / simpler / stabler in the future. This checklist is going to be BLASTED with [No QA] PRs in a bit though 😅

@roryabraham roryabraham added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Jul 14, 2022
@roryabraham
Copy link
Contributor

Okay, I think everything is working again. Will hold off on any further GitHub Actions changes until we get another production release out. @Expensify/applauseleads feel free to lock this whenever you are ready (presumably tomorrow at this point), and thanks for your patience. 🙇

@roryabraham roryabraham mentioned this issue Jul 14, 2022
Closed
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jul 14, 2022
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.1.84-11 🚀

@melvin-bot melvin-bot bot added the Monthly KSv2 label Jul 15, 2022
@mvtglobally
Copy link

Regression is completed

PR #9768 is failing due to #9923 repro in PROD, checking off
PR #9798 is failing due to #9918 repro in PROD, checking off
PR #9801 is blocked by #9922. Can someone validate as well?
PR #9804 is a PROD QA. Are we ok to check it off?

Issues logged
#9938
#9939
#9917
#9918
#9921
#9922
#9923
#9926
#9928
#9929
#9930
#9933

@mountiny
Copy link
Contributor

Not sure if related to your breaking changes @roryabraham 😄 but this PR #9865 which is in the list has been merged after the deploy and haven't have CP staging label added and does not have Deployed to Staging Botify comment so it should not be in the list most likely unless I missed something :D

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.84-12 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.84-12 has been deployed to staging 🎉

@mvtglobally
Copy link

@chiragsalian we are validating new CP. Let us know if anything else required to close this checklist

@mvtglobally
Copy link

Both CPs pass. Checked off

@marcaaron
Copy link
Contributor

Heads up, #9659 was a fail for me when testing reauthentication - found an issue and created a CP PR to fix it here.

@chiragsalian
Copy link
Contributor

@mvtglobally, You've mentioned,

PR #9801 is blocked by #9922.

but i see 9922 as checked off. Will you be able to test 9801?

PR #9804 is a PROD QA. Are we ok to check it off?

Yes, feel free to always check off any prod QA issues. I'll check this one this time.

@mvtglobally
Copy link

@chiragsalian we re-validated and PR is pass #9801. Checking off

@chiragsalian
Copy link
Contributor

chiragsalian commented Jul 18, 2022 •
edited
Loading

The only thing pending is #9659. We've just CP'd a fix. Waiting for it to get deployed to staging to test before we can ship this to production.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.1.84-13 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.1.84-13 has been deployed to staging 🎉

@chiragsalian
Copy link
Contributor

chiragsalian commented Jul 18, 2022 •
edited
Loading

Me and CarlosM tested #9961 and checked it off. Time to ship.

@chiragsalian
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging Monthly KSv2 StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@chiragsalian @marcaaron @mountiny @applausebot @mvtglobally @roryabraham @OSBotify