Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD]Android - Notification - Notifications leads to the wrong chat while online/offline, killed app #9930

Closed
kbecciv opened this issue Jul 14, 2022 · 5 comments
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority

Comments

@kbecciv
Copy link

kbecciv commented Jul 14, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login to the app, open different chat
  2. Kill the app
  3. Tap on the received notification
  4. Repeat while offline

Expected Result:

It should open NewDot to the correct chat, and the new message should be available.

Actual Result:

Wrong chat window is opened
The same behavior for offline/online scenario

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.84.11

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5648874_mobizen_20220714_233056.mp4
Screen_Recording_20220714-160904_New.Expensify.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2022

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Jul 14, 2022

Two issues had been closed #9179 and #6079

@alex-mechler
Copy link
Contributor

cc @neil-marcellini @AndrewGable since both of you have worked on notifications in the past

@alex-mechler alex-mechler added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Daily KSv2 Weekly KSv2 labels Jul 15, 2022
@alex-mechler alex-mechler removed their assignment Jul 15, 2022
@alex-mechler alex-mechler added the Weekly KSv2 label Jul 15, 2022
@AndrewGable
Copy link
Contributor

As mentioned in previous issues, if this is related to offline mode, I think we should wait until after the offline API refactoring is completed.

@AndrewGable AndrewGable added Monthly KSv2 and removed Weekly KSv2 labels Jul 15, 2022
@AndrewGable AndrewGable changed the title Android - Notification - Notifications leads to the wrong chat while online/offline, killed app [HOLD]Android - Notification - Notifications leads to the wrong chat while online/offline, killed app Jul 15, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 27, 2022

@kbecciv, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Not a priority
Projects
None yet
Development

No branches or pull requests

3 participants