use same phone number example at all the phone number errors #10197

Puneet-here · 2022-08-02T11:00:50Z

Details

We were using different phone number examples(one of them was also incorrect) at different errors, this PR uses the same number for all errors.

Fixed Issues

$ #9979

Tests

Go to login page
Type 2 digits and continue
Verify that the phone number is +15005550006 at the error

Go to concierge chat > Tap on phone icon
Type some wrong number or just alphabets
Verify that the phone number is +15005550006 at the error

Go to search and type one digit
Verify that the phone number is +15005550006 at the message

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

Go to login page
Type 2 digits and continue
Verify that the phone number is +15005550006 at the error

Go to concierge chat > Tap on phone icon
Type some wrong number or just alphabets
Verify that the phone number is +15005550006 at the error

Go to search and type one digit
Verify that the phone number is +15005550006 at the message

Verify that no errors appear in the JS console

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Puneet-here · 2022-08-02T11:17:03Z

src/languages/es.js

@@ -865,7 +865,7 @@ export default {
            pleaseSelectUser: 'Asegúrese de que el correo electrónico o el número de teléfono sean válidos (p. ej. +15005550006).',


I don't know why this message(pleaseSelectUser) is different in spanish, the english one doesn't have a number and says Please select a user from contacts.

Also I think we don't need it now, this error message is for a case when a user tries to invite without selecting a user but this case isn't possible because the invite button stays disabled. Also it looks like we aren't using it (getErrorText isn't being used)

App/src/pages/workspace/WorkspaceInvitePage.js

Lines 109 to 114 in 43933e3

getErrorText() {

const errors = lodashGet(this.props.policy, 'errors', {});

if (errors.noUserSelected) {

return this.props.translate('workspace.invite.pleaseSelectUser');

}

Should I remove getErrorText ?

Oh yeah, that looks like some dead code.
Nice catch!

Please feel free to remove pleaseSelectUser as it isn't being used anywhere.

rushatgabhane · 2022-08-02T17:44:19Z

src/languages/es.js

@@ -865,7 +865,7 @@ export default {
            pleaseSelectUser: 'Asegúrese de que el correo electrónico o el número de teléfono sean válidos (p. ej. +15005550006).',


Oh yeah, that looks like some dead code.
Nice catch!

Please feel free to remove pleaseSelectUser as it isn't being used anywhere.

rushatgabhane

Thanks for removing the dead code @Puneet-here!

@tgolen LGTM as well 🎉

PR Reviewer Checklist

I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn’t already exist
- The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

OSBotify · 2022-08-03T21:19:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-08-04T21:42:16Z

🚀 Deployed to staging by @tgolen in version: 1.1.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

use same phone number

f378720

Puneet-here requested a review from a team as a code owner August 2, 2022 11:00

melvin-bot bot requested review from rushatgabhane and tgolen and removed request for a team August 2, 2022 11:00

Puneet-here commented Aug 2, 2022

View reviewed changes

rushatgabhane suggested changes Aug 2, 2022

View reviewed changes

tgolen previously approved these changes Aug 2, 2022

View reviewed changes

Puneet-here dismissed tgolen’s stale review via 90d6f94 August 3, 2022 12:24

remove dead code

90d6f94

rushatgabhane approved these changes Aug 3, 2022

View reviewed changes

tgolen approved these changes Aug 3, 2022

View reviewed changes

tgolen merged commit 06b378d into Expensify:main Aug 3, 2022

OSBotify mentioned this pull request Aug 4, 2022

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed

kbecciv mentioned this pull request Aug 17, 2022

Login - When entering 2 digits, the wrong message is displayed #10430

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use same phone number example at all the phone number errors #10197

use same phone number example at all the phone number errors #10197

Puneet-here commented Aug 2, 2022

Puneet-here Aug 2, 2022

Puneet-here Aug 2, 2022

rushatgabhane Aug 2, 2022

rushatgabhane Aug 2, 2022

rushatgabhane left a comment

OSBotify commented Aug 3, 2022

OSBotify commented Aug 4, 2022

		@@ -865,7 +865,7 @@ export default {
		pleaseSelectUser: 'Asegúrese de que el correo electrónico o el número de teléfono sean válidos (p. ej. +15005550006).',

	getErrorText() {
	const errors = lodashGet(this.props.policy, 'errors', {});

	if (errors.noUserSelected) {
	return this.props.translate('workspace.invite.pleaseSelectUser');
	}

use same phone number example at all the phone number errors #10197

use same phone number example at all the phone number errors #10197

Conversation

Puneet-here commented Aug 2, 2022

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

Desktop

iOS

Android

Puneet-here Aug 2, 2022

Choose a reason for hiding this comment

Puneet-here Aug 2, 2022

Choose a reason for hiding this comment

rushatgabhane Aug 2, 2022

Choose a reason for hiding this comment

rushatgabhane Aug 2, 2022

Choose a reason for hiding this comment

rushatgabhane left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 3, 2022

OSBotify commented Aug 4, 2022