Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Fix staging gradle build #10306

Merged
merged 1 commit into from
Aug 8, 2022
Merged

[No QA] Fix staging gradle build #10306

merged 1 commit into from
Aug 8, 2022

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Aug 8, 2022

Details

Should fix failing Android deploys (example)

  • This PR updated the app version on main to 1.1.88-4
  • When CP'd to staging, that PR somehow introduced this code on staging, which should not have happened.

So even though we're not seeing a detailed log, I'm certain that is our problem. We are attempting to use the isNewArchitectureEnabled function when it is not defined on staging

Fixed Issues

$ n/a

Tests

Going to live-test this bad-boy

@roryabraham roryabraham requested a review from a team as a code owner August 8, 2022 18:41
@roryabraham roryabraham self-assigned this Aug 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team August 8, 2022 18:42
@roryabraham
Copy link
Contributor Author

Also we don't need the CP Staging label because we're merging this directly into staging.

@roryabraham roryabraham merged commit c9017fd into staging Aug 8, 2022
@roryabraham roryabraham deleted the Rory-FixGradleBuild branch August 8, 2022 18:45
@roryabraham
Copy link
Contributor Author

Deploy triggered here

@roryabraham
Copy link
Contributor Author

That didn't work because it wasn't an automated pull request

@roryabraham
Copy link
Contributor Author

Going to attempt a manual retry of the latest failed platformDeploy

@roryabraham
Copy link
Contributor Author

Not sure if it will use the latest staging code or not, but it's worth a shot

@OSBotify
Copy link
Contributor

OSBotify commented Aug 8, 2022

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.88-7 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants