Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove has draft collection #10532

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Remove has draft collection #10532

merged 3 commits into from
Aug 30, 2022

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Aug 24, 2022

We recently discussed the removal of these collections that only hold boolean values.

While starting to work on #7948 I wanted to start with fixing these drafts to help clean things up before getting into the meat of the issue.

Details

This PR removes the old Onyx collection for reportHasDraft_ and move the information to a hasDraft property on each report.

Fixed Issues

Related to #7948

Tests

Covered by unit tests

  • Verify that no errors appear in the JS console

QA Steps

  1. Open a chat
  2. Start writing a comment
  3. Verify the edit/pencil icon appears in the LHN for the active report
  4. While still having a draft comment, switch to another report
  5. Start writing a comment on the new report
  6. Verify that both reports have the edit/pencil icon showing, since they have drafts

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@tgolen tgolen self-assigned this Aug 24, 2022
@tgolen tgolen requested a review from a team as a code owner August 24, 2022 14:21
@tgolen tgolen mentioned this pull request Aug 24, 2022
1 task
@melvin-bot melvin-bot bot requested review from cristipaval and removed request for a team August 24, 2022 14:21
@tgolen tgolen merged commit b2d2cd3 into main Aug 30, 2022
@tgolen tgolen deleted the tgolen-remove-hasDraftCollection2 branch August 30, 2022 08:56
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @tgolen in version: 1.1.94-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants