[No QA] More sidebar link tests in preparation for refactoring #10714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgolen
changed the title
tgolen
changed the title
|
OK, HOLD is removed. I wanted to add tests to make sure that the sidebar rerenders things in the proper order when onyx data changes |
deetergp
approved these changes
Aug 31, 2022
luacmartins
approved these changes
Aug 31, 2022
| // with a draft on report 2 | ||
| // with the current user set to email9@ | ||
| // with a report that has a draft, a report that is pinned, and | ||
| // an outstanding IOU report that doesn't belong to the current user |
There was a problem hiding this comment.
Suggested change
| // an outstanding IOU report that doesn't belong to the current user | |
| // an outstanding IOU report that doesn't belong to the current user |
There was a problem hiding this comment.
I put that there intentionally to help visually separate the different conditions. I think I'll leave it there for now
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Issues
Part of #7948
Tests
None. Covered by unit tests.
QA Steps
None
cc @luacmartins