Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of setNativeProps #10934

Closed
wants to merge 35 commits into from
Closed

Remove usage of setNativeProps #10934

wants to merge 35 commits into from

Commits on Sep 8, 2022

  1. composer - move setNativeProps to state

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    8666d97 View commit details
    Browse the repository at this point in the history

  2. reportEdit - remove setNativeProps

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ecabcfc View commit details
    Browse the repository at this point in the history

  3. SigninPageForm - remove setNativeProps

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    1295ebb View commit details
    Browse the repository at this point in the history

  4. TextInput - replace setNativeProps with setAttribute

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    27020f5 View commit details
    Browse the repository at this point in the history

  5. Revert "SigninPageForm - remove setNativeProps" 

    This reverts commit 1295ebb.
    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    72bbc0b View commit details
    Browse the repository at this point in the history

  6. SignInPageForm - replace setNativeProps with setAttribute

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    ddfabdf View commit details
    Browse the repository at this point in the history

  7. TextInputLabel - replace setNativeProps with setAttribute

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    12fa935 View commit details
    Browse the repository at this point in the history

  8. BaseOptionsSelector - move setNativeProps to state

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    e45288e View commit details
    Browse the repository at this point in the history

  9. Form - move inputValues to state to remove setNativeProps

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    e2b07d2 View commit details
    Browse the repository at this point in the history

  10. InvertedFlatList - remove setNativeProps, pass style as a prop instead.

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    1cce3d5 View commit details
    Browse the repository at this point in the history

  11. Make Picker controlled only and remove setNativeProps

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    4c90e34 View commit details
    Browse the repository at this point in the history

  12. fix picker state

    @rushatgabhane
    rushatgabhane committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    1bfc4e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2022

  1. Merge remote-tracking branch 'origin/fix-storybook' into remove-setNa… 

    …tiveProps
    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    a0ff498 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/fix-storybook' into remove-setNa… 

    …tiveProps
    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    8528c0d View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/fix-storybook' into remove-setNa… 

    …tiveProps
    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    deeaef9 View commit details
    Browse the repository at this point in the history

  4. Revert "Make Picker controlled only and remove setNativeProps" 

    This reverts commit 4c90e34.
    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    b77ab39 View commit details
    Browse the repository at this point in the history

  5. Revert "fix picker state" 

    This reverts commit 1bfc4e2.
    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    3298fa7 View commit details
    Browse the repository at this point in the history

  6. fix stale Form values validation

    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    28fdeac View commit details
    Browse the repository at this point in the history

  7. remove setNativeProps from Picker

    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    38fd5ad View commit details
    Browse the repository at this point in the history

  8. remove unnecessary value from profile page

    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    e23f51c View commit details
    Browse the repository at this point in the history

  9. remove setNativeProps from reportSettingsPage

    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    103e340 View commit details
    Browse the repository at this point in the history

  10. fix eslint errors

    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    1192191 View commit details
    Browse the repository at this point in the history

  11. fix eslint errors

    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    237d0dd View commit details
    Browse the repository at this point in the history

  12. fix setAttribute

    @rushatgabhane
    rushatgabhane committed Sep 10, 2022
    Configuration menu
    Copy the full SHA
    7dd836f View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. make picker work with Form

    @rushatgabhane
    rushatgabhane committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    0644e1d View commit details
    Browse the repository at this point in the history

  2. fix lint errors

    @rushatgabhane
    rushatgabhane committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    e0fb68b View commit details
    Browse the repository at this point in the history

  3. pass value to Form inputs

    @rushatgabhane
    rushatgabhane committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    a8b8e7b View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Merge branch 'Expensify:main' into remove-setNativeProps

    @rushatgabhane
    rushatgabhane authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    97ebb65 View commit details
    Browse the repository at this point in the history

  2. cleaner styleee 

    Co-authored-by: Rajat Parashar <parasharrajat@users.noreply.github.com>
    @rushatgabhane @parasharrajat
    rushatgabhane and parasharrajat authored Sep 13, 2022
    Configuration menu
    Copy the full SHA
    5f1ecfe View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. Merge branch 'Expensify:main' into remove-setNativeProps

    @rushatgabhane
    rushatgabhane authored Sep 14, 2022
    Configuration menu
    Copy the full SHA
    b4d3bdd View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2022

  1. init value in state

    @rushatgabhane
    rushatgabhane committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    74cb3cb View commit details
    Browse the repository at this point in the history

  2. fix picker ref

    @rushatgabhane
    rushatgabhane committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    cbf0415 View commit details
    Browse the repository at this point in the history

  3. rm unnecessary picker prop

    @rushatgabhane
    rushatgabhane committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    358a77f View commit details
    Browse the repository at this point in the history

  4. profile page - use value prop for pickers

    @rushatgabhane
    rushatgabhane committed Sep 15, 2022
    Configuration menu
    Copy the full SHA
    aaab06b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'Expensify:main' into remove-setNativeProps

    @rushatgabhane
    rushatgabhane authored Sep 15, 2022
    Configuration menu
    Copy the full SHA
    2122178 View commit details
    Browse the repository at this point in the history