-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render banner in Concierge chat #11363
Conversation
Looks like you modified This file contains deprecated workarounds for limitations of Drop a note in #expensify-open-source to discuss with the team how to proceed. |
// https://github.com/react-navigation/react-navigation/blob/94ab791cae5061455f036cd3f6bc7fa63167e7c7/packages/routers/src/DrawerRouter.tsx#L142 | ||
const hasDrawerhistory = _.find(state.history || [], h => h.type === 'drawer'); | ||
if (!hasDrawerhistory || currentState.type !== 'drawer') { | ||
const drawerHistoryItem = _.find(state.history || [], h => h.type === 'drawer'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More context about the changes in DeprecatedCustomActions.js
this thread
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tests well! We have some conflicts though. Also, one thing I noticed is that the banner will show up again upon page refresh - wonder if we would want to have it only reappear after say, 1 week or something? I will bring it up in the issue (NAB for getting this PR out the door anyway)
Updated! Conflicts resolved :) |
Triggered auto assignment to @cead22 ( |
@yuwenmemon looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Incorrect @MelvinBot |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @yuwenmemon in version: 1.2.11-0 🚀
|
Tested on staging and it's a pass 🎉 |
🚀 Deployed to production by @AndrewGable in version: 1.2.11-4 🚀
|
Render banner in Concierge chat
FYI, I believe this PR caused this bug: #13452 |
{ | ||
props.shouldRenderHTML | ||
? <RenderHTML html={props.text} /> | ||
: <Text style={[...props.textStyles]} onPress={props.onPress}>{props.text}</Text> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, just noting that we should have used flexWrap to prevent text overflow on native.
Details
Adds a banner to the Concierge chat to direct managed users to their account manager chat.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/227162
Tests
./script/clitools.sh generator:domain
x
button and verify that the banner is closedPR Review Checklist
Contributor (PR Author) Checklist
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
displayName
propertythis
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)QA Steps
Screenshots
Web
web.mov
Mobile Web - Chrome
Mobile Web - Safari
mweb.mov
Desktop
desktop.mov
iOS
ios.mov
Android
android.mov