Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Keyboard fix on attachment download #12053

Merged
merged 7 commits into from
Oct 24, 2022
Merged

Fix: Keyboard fix on attachment download #12053

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1dabf56
add keyboard dismiss on attachment download
Uros787 Oct 21, 2022
3d7d140
fix lint
Uros787 Oct 21, 2022
13d96f1
moved to a method and added a comment explaining the fix
Uros787 Oct 23, 2022
3b97604
revert wrong changes
Uros787 Oct 23, 2022
eaaa90b
pass sourceURL as a prop, fix lint issues
Uros787 Oct 23, 2022
c1c68f7
rename method and minor comment changes
Uros787 Oct 24, 2022
8d81789
change comment
Uros787 Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/AttachmentModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ class AttachmentModal extends PureComponent {
shouldShowBorderBottom
shouldShowDownloadButton={this.props.allowDownload}
onDownloadButtonPress={() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this to a method. Also we should add a comment to explain why we need Keyboard.dismiss()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, let me know if its okay

fileDownload(sourceURL, this.props.originalFileName)
fileDownload(sourceURL, this.props.originalFileName);
Keyboard.dismiss();
}}
onCloseButtonPress={() => this.setState({isModalOpen: false})}
Expand Down