Change background color for mWeb scrolling #13278

grgia · 2022-12-02T17:54:08Z

Details

Changes the body color to match the dark AppBG, so scrolling around on mobile web doesn't show a white background.

I decided to add it to the splash screen script since it is imported with webpack and listens for DOMContentLoaded.

Screen.Recording.2022-12-02.at.9.40.55.AM.mov

Fixed Issues

$ #13085
#13219 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console
Open App in web, chrome, and safari
Ensure that no white background shows while scrolling/dragging the application

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2022-12-06.at.10.55.54.AM.mov

Mobile Web - Chrome

Screen.Recording.2022-12-06.at.11.00.15.AM.mov

Mobile Web - Safari

Screen.Recording.2022-12-06.at.11.00.59.AM.mov

Desktop

Screen.Recording.2022-12-06.at.11.02.14.AM.mov

iOS

N/A - web only change

Android

N/A - web only change

melvin-bot · 2022-12-06T19:08:39Z

@Santhosh-Sellavel @marcaaron One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2022-12-06T19:12:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2022-12-07.at.12.45.33.AM.mov

Mobile Web - Chrome

Screen.Recording.2022-12-07.at.12.56.40.AM.mov

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.-.2022-12-07.at.00.51.41.mp4

Desktop

Screen.Recording.2022-12-07.at.12.48.26.AM.mov

iOS

N/A

Android

N/A

web/splash/splash.js

marcaaron · 2022-12-06T19:35:12Z

web/splash/splash.js

@@ -11,6 +11,10 @@ document.addEventListener('DOMContentLoaded', () => {
    const root = document.getElementById('root');
    splash.style.backgroundColor = themeColors.appBG;

+    // // set app background color


Suggested change

// // set app background color

// Set app background color

marcaaron · 2022-12-06T19:37:46Z

web/index.html

@@ -70,7 +70,7 @@
        <script src="https://polyfill.io/v3/polyfill.min.js?features=default%2CResizeObserver&flags=gated"></script>
    <% } %>
 </head>
-<body>
+<body id="bg">


Probably don't need an id for this and could do something like:

const body = document.querySelector('body');

I tried that at first and am just now realizing I used the wrong selector, Thanks!

Santhosh-Sellavel

Waiting for marc's comments needs to be addressed otherwise looks good, tests well!

grgia · 2022-12-07T20:10:41Z

oops @marcaaron you approved right when I was clicking re-request review, sorry! 😅

OSBotify · 2022-12-07T20:17:18Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-12-13T22:38:50Z

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Change background color for mWeb scrolling

164cc04

grgia requested a review from roryabraham December 2, 2022 17:54

grgia self-assigned this Dec 2, 2022

grgia mentioned this pull request Dec 2, 2022

[HOLD for payment 2022-12-20] While resizing, a white window background is shown #13085

Closed

Add body color on web-only (fix ios errors)

0ce874a

grgia marked this pull request as ready for review December 6, 2022 19:08

grgia requested a review from a team as a code owner December 6, 2022 19:08

melvin-bot bot requested review from marcaaron and Santhosh-Sellavel and removed request for a team December 6, 2022 19:08

marcaaron reviewed Dec 6, 2022

View reviewed changes

web/splash/splash.js Show resolved Hide resolved

marcaaron reviewed Dec 6, 2022

View reviewed changes

Santhosh-Sellavel reviewed Dec 6, 2022

View reviewed changes

grgia added 2 commits December 7, 2022 12:05

Use querySelector, update comment

c7a2728

More descriptive comment

fcbe4c0

marcaaron approved these changes Dec 7, 2022

View reviewed changes

grgia requested review from marcaaron and Santhosh-Sellavel December 7, 2022 20:10

marcaaron approved these changes Dec 7, 2022

View reviewed changes

marcaaron removed the request for review from roryabraham December 7, 2022 20:12

marcaaron merged commit cb869cf into main Dec 7, 2022

marcaaron deleted the georgia-dark-fix branch December 7, 2022 20:12

francoisl mentioned this pull request Dec 8, 2022

Deploy Checklist: New Expensify 2022-12-07 #13431

Closed

72 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change background color for mWeb scrolling #13278

Change background color for mWeb scrolling #13278

grgia commented Dec 2, 2022 •

edited

Loading

melvin-bot bot commented Dec 6, 2022

Santhosh-Sellavel commented Dec 6, 2022 •

edited by marcaaron

Loading

marcaaron Dec 6, 2022

marcaaron Dec 6, 2022

grgia Dec 7, 2022

Santhosh-Sellavel left a comment

grgia commented Dec 7, 2022

OSBotify commented Dec 7, 2022

OSBotify commented Dec 13, 2022

Change background color for mWeb scrolling #13278

Change background color for mWeb scrolling #13278

Conversation

grgia commented Dec 2, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 6, 2022

Santhosh-Sellavel commented Dec 6, 2022 • edited by marcaaron Loading

Reviewer Checklist

Screenshots/Videos

marcaaron Dec 6, 2022

Choose a reason for hiding this comment

marcaaron Dec 6, 2022

Choose a reason for hiding this comment

grgia Dec 7, 2022

Choose a reason for hiding this comment

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

grgia commented Dec 7, 2022

OSBotify commented Dec 7, 2022

OSBotify commented Dec 13, 2022

grgia commented Dec 2, 2022 •

edited

Loading

Santhosh-Sellavel commented Dec 6, 2022 •

edited by marcaaron

Loading