Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Image][Performance] Fast Image with Auth Token Header Caching (revert follow-up) #13304

Merged
merged 20 commits into from
Jan 17, 2023
Merged

[Image][Performance] Fast Image with Auth Token Header Caching (revert follow-up) #13304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
ffbb219
fix: naming `FastImage` -> `Image`
thomas-coldwell Dec 1, 2022
13de0b8
fix: Add auth token at Image component level
thomas-coldwell Dec 1, 2022
e2e71f7
Merge branch 'main' into @thomas/fast-image-caching-2
thomas-coldwell Dec 14, 2022
a219d1b
fix: Change to upstream `react-native-fast-image` package
thomas-coldwell Jan 3, 2023
8327006
fix: Patch for upstream PR
thomas-coldwell Jan 3, 2023
6917ccd
Merge branch 'main' into @thomas/fast-image-caching-2
thomas-coldwell Jan 3, 2023
a5894b5
pod install
thomas-coldwell Jan 3, 2023
f97273b
fix: nabs
thomas-coldwell Jan 4, 2023
4f85de3
fix: Review comments
thomas-coldwell Jan 5, 2023
410e283
fix: prop type changes
thomas-coldwell Jan 5, 2023
af6a53f
fix: Only show loading indictator when actually downloading image in …
thomas-coldwell Jan 5, 2023
8ab3c7d
fix: Review comments
thomas-coldwell Jan 6, 2023
eab7f6a
fix: improve naming
thomas-coldwell Jan 6, 2023
5b9db07
fix: Only set loading state if image is being downloaded
thomas-coldwell Jan 7, 2023
72f52b3
fix: Layout shift for small images
thomas-coldwell Jan 8, 2023
ed67ec4
fix: Update patch
thomas-coldwell Jan 8, 2023
16d7738
fix: Show loading state for image load + layout calculation
thomas-coldwell Jan 11, 2023
3810756
fix: Remove obsolete comment
thomas-coldwell Jan 11, 2023
c262265
fix: Remove duplicate prop-type
thomas-coldwell Jan 12, 2023
0a17bfa
fix: Remove unncessary image load check
thomas-coldwell Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ PODS:
- React-Core
- RNDateTimePicker (3.5.2):
- React-Core
- RNFastImage (8.5.11):
- RNFastImage (8.6.3):
- React-Core
- SDWebImage (~> 5.11.1)
- SDWebImageWebPCoder (~> 0.8.4)
Expand Down Expand Up @@ -722,7 +722,7 @@ DEPENDENCIES:
- "RNCClipboard (from `../node_modules/@react-native-community/clipboard`)"
- "RNCPicker (from `../node_modules/@react-native-picker/picker`)"
- "RNDateTimePicker (from `../node_modules/@react-native-community/datetimepicker`)"
- "RNFastImage (from `../node_modules/@pieter-pot/react-native-fast-image`)"
- RNFastImage (from `../node_modules/react-native-fast-image`)
thomas-coldwell marked this conversation as resolved.
Show resolved Hide resolved
- "RNFBAnalytics (from `../node_modules/@react-native-firebase/analytics`)"
- "RNFBApp (from `../node_modules/@react-native-firebase/app`)"
- "RNFBCrashlytics (from `../node_modules/@react-native-firebase/crashlytics`)"
Expand Down Expand Up @@ -890,7 +890,7 @@ EXTERNAL SOURCES:
RNDateTimePicker:
:path: "../node_modules/@react-native-community/datetimepicker"
RNFastImage:
:path: "../node_modules/@pieter-pot/react-native-fast-image"
:path: "../node_modules/react-native-fast-image"
RNFBAnalytics:
:path: "../node_modules/@react-native-firebase/analytics"
RNFBApp:
Expand Down Expand Up @@ -1005,7 +1005,7 @@ SPEC CHECKSUMS:
RNCClipboard: 41d8d918092ae8e676f18adada19104fa3e68495
RNCPicker: 0b65be85fe7954fbb2062ef079e3d1cde252d888
RNDateTimePicker: 7658208086d86d09e1627b5c34ba0cf237c60140
RNFastImage: 1f2cab428712a4baaf78d6169eaec7f622556dd7
RNFastImage: 5c9c9fed9c076e521b3f509fe79e790418a544e8
RNFBAnalytics: f76bfa164ac235b00505deb9fc1776634056898c
RNFBApp: 729c0666395b1953198dc4a1ec6deb8fbe1c302e
RNFBCrashlytics: 2061ca863e8e2fa1aae9b12477d7dfa8e88ca0f9
Expand Down
32 changes: 16 additions & 16 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"@gorhom/portal": "^1.0.14",
"@oguzhnatly/react-native-image-manipulator": "github:Expensify/react-native-image-manipulator#c5f654fc9d0ad7cc5b89d50b34ecf8b0e3f4d050",
"@onfido/react-native-sdk": "7.0.1",
"@pieter-pot/react-native-fast-image": "8.5.11",
"@react-native-async-storage/async-storage": "^1.17.10",
"@react-native-community/cameraroll": "git+https://github.com/react-native-cameraroll/react-native-cameraroll.git#3f0aed96db68e134f199171c7b06c1b4d6cb382b",
"@react-native-community/clipboard": "^1.5.1",
Expand Down Expand Up @@ -93,6 +92,7 @@
"react-native-collapsible": "^1.6.0",
"react-native-config": "^1.4.5",
"react-native-document-picker": "^8.0.0",
"react-native-fast-image": "^8.6.3",
"react-native-gesture-handler": "2.6.0",
"react-native-google-places-autocomplete": "git+https://github.com/Expensify/react-native-google-places-autocomplete.git#3bbd17d63e6c38d38d857b50f6037c1c0376ff06",
"react-native-haptic-feedback": "^1.13.0",
Expand Down
Loading