Remove right icon from Electron notifications. #13330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grgia
changed the title
melvin-bot
bot
requested review from
aimane-chnaif and
puneetlath
and removed request for
a team
|
@aimane-chnaif @puneetlath One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Does anyone have an opinion on how I should approach screenshots for this PR? This change should only affect desktop app notifications and doesn't touch the App itself. |
arosiclair
reviewed
Dec 5, 2022
|
I think the general approach would be to still take a screenshot of a notification from each app. Just to show that they still look right. |
|
My thought: |
|
@arosiclair Nice catch! In that case, we might want to separate desktop/browser. **Before ** **After ** |
grgia
changed the title
grgia
changed the title
arosiclair
approved these changes
Dec 6, 2022
Reviewer Checklist
Screenshots/VideosWeb
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
NOTE: Not sure if this should be reported as a bug but I can't get push notification permission alert to grant/deny permission after login on my iPhone. Therefore push notification cannot be received. I tested on both testflight staging and appstore version. Android
|
|
Shouldn’t the desktop notification have the Expensify icon logo instead of
the generic electron icon?
…On Tue, Dec 6, 2022 at 8:53 AM Aimane Chnaif ***@***.***> wrote:
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are
checked off).
- I verified the correct issue is linked in the ### Fixed Issues
section above
- I verified testing steps are clear and they cover the changes made
in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in
the QA steps section
- I verified the steps cover any possible failure scenarios (i.e.
verify an input displays the correct error message if the entered data is
not correct)
- I turned off my network connection and tested it while offline to
ensure it matches the expected behavior (i.e. verify the default avatar
icon is displayed if app is offline)
- I checked that screenshots or videos are included for tests on all
platforms
<https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms>
- I included screenshots or videos for tests on all platforms
<https://github.com/Expensify/App/blob/main/contributingGuides/CONTRIBUTING.md#make-sure-you-can-test-on-all-platforms>
- I verified tests pass on *all platforms* & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this
PR, I either fixed them (preferred) or linked to where I reported them in
Slack
- I verified proper code patterns were followed (see Reviewing the code
<https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md#reviewing-the-code>)
- I verified that any callback methods that were added or modified
are named for what the method does and never what callback they handle
(i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self
explanatory
- I verified that any new or modified comments were clear, correct
English, and explained "why" the code was doing something instead of only
explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all
src/languages/* files
- I verified any copy / text that was added to the app is correct
English and approved by marketing by adding the Waiting for Copy
label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any
new files or renamed files. All non-platform specific files are named after
what they export and are not named "index.js". All platform-specific files
are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md
<https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#jsdocs>)
were followed
- If a new code pattern is added I verified it was agreed to be used
by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review
Guidelines
<https://github.com/Expensify/App/blob/main/contributingGuides/PR_REVIEW_GUIDELINES.md>
- I verified other components that can be impacted by these changes
have been tested, and I retested again (i.e. if the PR modifies a shared
library or component like Avatar, I verified the components using
Avatar have been tested & I retested again)
- I verified all code is DRY (the PR doesn't include any logic written
more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in
CONST.js or at the top of the file that uses the constant) are defined as
such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment
above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the
purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for
rendering and nothing else
- For Class Components, any internal methods passed to components
event handlers are bound to this properly so there are no scoping
issues (i.e. for onClick={this.submit} the method this.submit
should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound
(i.e. avoid this.submit = this.submit.bind(this); if this.submit is
never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its
purpose, and it is broken down into smaller components in order to separate
concerns and functions
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils
<https://github.com/Expensify/App/blob/main/src/styles/StyleUtils.js>
function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies a generic component, I tested and verified that
those changes do not break usages of that component in the rest of the App
(i.e. if a shared library or component like Avatar is modified, I
verified that Avatar is working as expected in all cases)
- If the PR modifies a component related to any of the existing
Storybook stories, I tested and verified all stories for that component are
still working as expected.
- I have checked off every checkbox in the PR reviewer checklist,
including those that don't apply to this PR.
Screenshots/Videos Web [image: web]
<https://user-images.githubusercontent.com/96077027/205969331-832e396b-d72b-46a2-8857-08fd1eeddfce.png> Mobile
Web - Chrome
[image: mchrome]
<https://user-images.githubusercontent.com/96077027/205971265-19b7ffd1-ed1a-41b5-a88a-10521452b785.png>
Mobile Web - Safari
[image: msafari]
<https://user-images.githubusercontent.com/96077027/205972379-3de46743-a404-4ef0-a8ca-042c90ed5523.png>
Desktop [image: desktop]
<https://user-images.githubusercontent.com/96077027/205972482-b5b86fe2-d896-4e52-93aa-b4c5a11ee139.png>
iOS
[image: ios]
<https://user-images.githubusercontent.com/96077027/205972585-075ea579-0526-47be-8cd0-ce796c6a85c9.png>
NOTE: Not sure if this should be reported as a bug but I can't get push
notification permission alert to grant/deny permission after login on my
iPhone. Therefore push notification cannot be received. I tested on both
testflight staging and appstore version.
Android
[image: android]
<https://user-images.githubusercontent.com/96077027/205972536-d2d5870c-7068-4e3c-97df-9886ab223d95.jpg>
—
Reply to this email directly, view it on GitHub
<#13330 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARWH5TB25ZA4OPNN7JE5LLWL54RTANCNFSM6AAAAAASURXXPM>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
As @grgia said |
puneetlath
approved these changes
Dec 6, 2022
|
Sounds good, thanks for clarifying. |
|
Great discussion, all looks good. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
72 tasks
|
🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Currently, our desktop notifications look like this:
This PR removes the right circular icon from the notification for desktop.
Fixed Issues
$ #13296
Tests
Verify that no errors appear in the JS console
Ensure that your OS system settings allows notifications from Electron
Log into account A on Desktop App
Log into account B on Chrome
Send a message from B to A, ensure that only left electron icon is present.
Send a message from A to B, ensure that Chrome icon AND the right circular Expensify icon is present.
Ensure IOS / Android notifications look correct (NOTE THIS SO, IOS cannot be tested on an emulator )
Note: This will require staging QA to properly test the notification style with desktop icons.
** Before **
** After **
Offline tests
QA Steps
Verify that no errors appear in the JS console
Ensure that your OS system settings allows notifications from Expensify Staging
Log into account A on Desktop App
Log into account B on Chrome
Send a message from B to A, and ensure that Expensify Staging Logo is present on left.
Send a message from A to B, and ensure that the Chrome icon AND the right circular Expensify icon is present.
Ensure IOS / Android notifications look correct
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*filesWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Screenshots/Videos
Web
Mobile Web - Chrome
N/A - notifications aren't available on mobile web
Mobile Web - Safari
N/A - notifications aren't available on mobile web
Desktop
iOS
N/A - need to test on device
Android
N/A