Clear request queue and reconnection callbacks upon sign out #13393

MariaHCD · 2022-12-07T11:12:44Z

Details

Fixed Issues

$ #11850 (Second part of the solution here)
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Log into NewDot
Set the App state to offline
Perform some actions while offline (eg. opening chats, sending messages)
Sign out of NewDot
Ensure the network console is open
Set the App state to online
Verify that there are no API requests that fail with Session expired

Offline tests

QA Steps

Same as test steps (Note: can only be tested on web)

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2022-12-07.at.11.15.07.AM.mov

Mobile Web - Chrome

NA; Unable to observe the network console

Mobile Web - Safari

NA; Unable to observe the network console

Desktop

Screen.Recording.2022-12-07.at.11.29.57.AM.mov

iOS

NA; Unable to observe the network console

Android

NA; Unable to observe the network console

…ueue

melvin-bot · 2022-12-07T11:57:06Z

@Santhosh-Sellavel @PauloGasparSv One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2022-12-07T16:39:20Z

@luacmartins @MariaHCD Are we fine with this http://localhost:8080/api?command=AuthenticatePusher is failing with 403 even in a new session ?

Is this considered as a test pass, after logout no API failed with 403 or the session expired?

Screen.Recording.2022-12-07.at.10.05.06.PM.mov

Santhosh-Sellavel

Just request some clarification here

luacmartins · 2022-12-07T17:22:13Z

src/libs/NetworkConnection.js

+ * Delete all queued reconnection callbacks
+ */
+function clearReconnectionCallbacks() {
+    _.each(_.keys(reconnectionCallbacks), key => delete reconnectionCallbacks[key]);


NAB We could also change const reconnectionCallbacks = {} to let reconnectionCallbacks = {} and then assign it to an empty object here.

Suggested change

_.each(_.keys(reconnectionCallbacks), key => delete reconnectionCallbacks[key]);

reconnectionCallbacks = {};

luacmartins · 2022-12-07T17:27:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

desktop.mov

iOS

N/A

Android

N/A

Santhosh-Sellavel · 2022-12-07T17:35:13Z

@luacmartins bump on this #13393 (comment)

luacmartins · 2022-12-07T18:05:22Z

@Santhosh-Sellavel that 403 seems to be unrelated to these changes. Is that consistently failing for you? Does that happen on main too?

PauloGasparSv

LGTM! Great fix :D

Web

Screen.Recording.2022-12-07.at.14.54.52.mov

Mobile Web - Chrome

N/A

Mobile Web - Safari

N/A

Desktop

Screen.Recording.2022-12-07.at.15.04.16.mov

iOS

N/A

Android

N/A

PauloGasparSv · 2022-12-07T18:17:03Z

Does that happen on main too?

Just tested main and I didn't see the request. No idea what it is but looks harmless right? I think we can approve @Santhosh-Sellavel : )

Santhosh-Sellavel · 2022-12-07T18:18:05Z

@Santhosh-Sellavel that 403 seems to be unrelated to these changes. Is that consistently failing for you? Does that happen on main too?

Yes Consistently occurs for me on the main too. Irrelevant here then, approving shortly after filling my checklist!

Santhosh-Sellavel · 2022-12-07T18:21:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

WEB_ClearReq.mov

Desktop

Screen.Recording.2022-12-07.at.11.51.14.PM.mov

Santhosh-Sellavel

LGTM Tests well!

OSBotify · 2022-12-07T18:36:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-12-13T22:39:14Z

🚀 Deployed to production by @chiragsalian in version: 1.2.38-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

MariaHCD added 3 commits December 6, 2022 16:35

Clear request queue when signing out

6100fa5

Clear reconnection callbacks upon signout

3358a25

Merge remote-tracking branch 'origin/main' into maria-clear-request-q…

a1e68b6

…ueue

MariaHCD self-assigned this Dec 7, 2022

MariaHCD added 2 commits December 7, 2022 11:44

Clear reconnection callbacks upon sign out

87e6a23

Fix lint error

565d424

MariaHCD marked this pull request as ready for review December 7, 2022 11:56

MariaHCD requested a review from a team as a code owner December 7, 2022 11:56

melvin-bot bot requested review from PauloGasparSv and Santhosh-Sellavel and removed request for a team December 7, 2022 11:57

MariaHCD requested a review from luacmartins December 7, 2022 11:57

Santhosh-Sellavel reviewed Dec 7, 2022

View reviewed changes

luacmartins approved these changes Dec 7, 2022

View reviewed changes

PauloGasparSv approved these changes Dec 7, 2022

View reviewed changes

Santhosh-Sellavel approved these changes Dec 7, 2022

View reviewed changes

luacmartins merged commit 906f8a8 into main Dec 7, 2022

luacmartins deleted the maria-clear-request-queue branch December 7, 2022 18:32

francoisl mentioned this pull request Dec 8, 2022

Deploy Checklist: New Expensify 2022-12-07 #13431

Closed

72 tasks

melvin-bot bot mentioned this pull request Dec 13, 2022

[$1000] [HOLD for payment 2022-12-20] BUG: Offline requests are triggered after signing out #11850

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clear request queue and reconnection callbacks upon sign out #13393

Clear request queue and reconnection callbacks upon sign out #13393

MariaHCD commented Dec 7, 2022 •

edited

Loading

melvin-bot bot commented Dec 7, 2022

Santhosh-Sellavel commented Dec 7, 2022

Santhosh-Sellavel left a comment •

edited

Loading

luacmartins Dec 7, 2022

luacmartins commented Dec 7, 2022 •

edited

Loading

Santhosh-Sellavel commented Dec 7, 2022

luacmartins commented Dec 7, 2022

PauloGasparSv left a comment

PauloGasparSv commented Dec 7, 2022

Santhosh-Sellavel commented Dec 7, 2022

Santhosh-Sellavel commented Dec 7, 2022 •

edited

Loading

Santhosh-Sellavel left a comment

OSBotify commented Dec 7, 2022

OSBotify commented Dec 13, 2022

	_.each(_.keys(reconnectionCallbacks), key => delete reconnectionCallbacks[key]);
	reconnectionCallbacks = {};

Clear request queue and reconnection callbacks upon sign out #13393

Clear request queue and reconnection callbacks upon sign out #13393

Conversation

MariaHCD commented Dec 7, 2022 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 7, 2022

Santhosh-Sellavel commented Dec 7, 2022

Is this considered as a test pass, after logout no API failed with 403 or the session expired?

Santhosh-Sellavel left a comment • edited Loading

Choose a reason for hiding this comment

luacmartins Dec 7, 2022

Choose a reason for hiding this comment

luacmartins commented Dec 7, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel commented Dec 7, 2022

luacmartins commented Dec 7, 2022

PauloGasparSv left a comment

Choose a reason for hiding this comment

PauloGasparSv commented Dec 7, 2022

Santhosh-Sellavel commented Dec 7, 2022

Santhosh-Sellavel commented Dec 7, 2022 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 7, 2022

OSBotify commented Dec 13, 2022

MariaHCD commented Dec 7, 2022 •

edited

Loading

Santhosh-Sellavel left a comment •

edited

Loading

luacmartins commented Dec 7, 2022 •

edited

Loading

Santhosh-Sellavel commented Dec 7, 2022 •

edited

Loading