Update expensify-common dependency #13394
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Updates
expensify-common
version to add a bug fix.Fixed Issues
$ #13073
Tests
Tested the PR with the changes in the
expensify-common
repoOffline tests
There are no changes with impact on the networking layer.
QA Steps
test@gmail.com
*test@gmail.com*
_test@gmail.com_
*_test@gmail.com_*
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots/Videos
Web
https://user-images.githubusercontent.com/18078393/206176641-75ac2f0e-f410-4142-b6dd-b4083f0b74f7.mp4Mobile Web - Chrome
https://user-images.githubusercontent.com/18078393/206176695-712e579f-21f0-4751-9b07-05d5baf124b2.mp4Mobile Web - Safari
https://user-images.githubusercontent.com/18078393/206176747-7a42366e-920d-4f97-9bf6-36bb05ef7b6e.mp4Desktop
https://user-images.githubusercontent.com/18078393/206176769-afdb7acc-8aa4-468d-a67e-50a204faf9d6.mp4iOS
https://user-images.githubusercontent.com/18078393/206176800-f1b8db2b-71c8-4bc9-8cb3-7f65893775e1.mp4Android
https://user-images.githubusercontent.com/18078393/206176844-1834b134-1f53-4a6f-ba36-7ecabfb444ed.mp4