-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CODEOWNERS so that we don't accidentally deploy a new version of react-native-onyx #13952
Conversation
@alex-mechler Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
I'll go ahead and merge this since it's a pretty fair concern. The failing tests are OK since the checklists don't apply to the changes in this PR. |
@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @luacmartins in version: 1.2.48-2 🚀
|
🚀 Deployed to production by @luacmartins in version: 1.2.49-0 🚀
|
Problem
react-native-onyx
has had this PR merged tomain
which adds SQLite support, but we are not ready to deploy it to App yet.Solution
I will review all PRs with changes to
package.json
to ensure it doesn't get deployed.Tests
None
Offline tests
None
QA Steps
Internal QA:
package.json
PR Author Checklist
Checklist doesn't apply to any of the changes in this PR
Screenshots/Videos
Screenshots don't apply to this PR