Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CODEOWNERS so that we don't accidentally deploy a new version of react-native-onyx #13952

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Jan 3, 2023

Problem

react-native-onyx has had this PR merged to main which adds SQLite support, but we are not ready to deploy it to App yet.

Solution

I will review all PRs with changes to package.json to ensure it doesn't get deployed.

Tests

None

Offline tests

None

QA Steps

Internal QA:

  1. Create a PR that modifies package.json
  2. Verify that I am assigned to it for review

PR Author Checklist

Checklist doesn't apply to any of the changes in this PR

Screenshots/Videos

Screenshots don't apply to this PR

@tgolen tgolen requested a review from puneetlath January 3, 2023 01:49
@tgolen tgolen requested a review from a team as a code owner January 3, 2023 01:49
@tgolen tgolen self-assigned this Jan 3, 2023
@melvin-bot melvin-bot bot requested review from alex-mechler and removed request for a team January 3, 2023 01:50
@melvin-bot
Copy link

melvin-bot bot commented Jan 3, 2023

@alex-mechler Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@tgolen tgolen added the InternalQA This pull request required internal QA label Jan 3, 2023
@tgolen
Copy link
Contributor Author

tgolen commented Jan 3, 2023

I'll go ahead and merge this since it's a pretty fair concern. The failing tests are OK since the checklists don't apply to the changes in this PR.

@tgolen tgolen merged commit 1548824 into main Jan 3, 2023
@tgolen tgolen deleted the tgolen-patch-3 branch January 3, 2023 02:40
@melvin-bot melvin-bot bot added the Emergency label Jan 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 3, 2023

@tgolen looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@tgolen tgolen removed the Emergency label Jan 3, 2023
@OSBotify
Copy link
Contributor

OSBotify commented Jan 3, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2023

🚀 Deployed to staging by @tgolen in version: 1.2.48-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@luacmartins luacmartins mentioned this pull request Jan 4, 2023
53 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Jan 5, 2023

🚀 Deployed to production by @luacmartins in version: 1.2.48-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2023

🚀 Deployed to production by @luacmartins in version: 1.2.49-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
InternalQA This pull request required internal QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants