Fix emoji header alignment

[daraksha-dk]

Details

#14462 (comment)

Fixed Issues

$ #14462
PROPOSAL: #14462 (comment)

Tests

1. Open the app
2. Go to any chat
3. Open emoji picker
4. Verify that emoji titles are vertically centered

• Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

1. Open the app
2. Go to any chat
3. Open emoji picker
4. Verify that emoji titles are vertically centered

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

title-android.mp4

[melvin-bot]

@pecanoro @thesahindia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[thesahindia]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[thesahindia]

Tested well for me!

All yours @pecanoro

[pecanoro]

Tested and seems to work well (unless I missed something). Merging!

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	697.635 ms → 712.045 ms (+14.410 ms, +2.1%)
Open Search Page TTI	602.616 ms → 610.524 ms (+7.908 ms, +1.3%)
App start regularAppStart	0.014 ms → 0.015 ms (+0.000 ms, +2.2%)
App start nativeLaunch	19.759 ms → 19.742 ms (-0.017 ms, ±0.0%)
App start runJsBundle	200.563 ms → 194.500 ms (-6.063 ms, -3.0%)

Show details

Name	Duration
App start TTI	Baseline Mean: 697.635 ms Stdev: 30.937 ms (4.4%) Runs: 629.2971499999985 654.4599389999639 656.139661999885 665.5241630000528 666.6108550000936 672.4258499999996 675.8966550000478 676.8976900000125 678.4591010001022 679.5118499998935 679.8798010000028 681.3211880000308 681.4243050001096 684.1047400000971 691.0855219999794 694.2333360000048 696.8948139999993 703.7426050000358 706.5383329999167 709.0793290000875 711.8467570000794 716.3766040001065 717.3243120000698 719.5237829999533 722.8073559999466 724.0576849998906 727.720236999914 737.5618749998976 739.6516170001123 751.8454189999029 774.4497340000235 Current Mean: 712.045 ms Stdev: 36.852 ms (5.2%) Runs: 653.6752400000114 656.6220400000457 663.3250229998957 673.2534350000788 674.2491069999523 676.346537000034 677.5013810000382 682.2851970000193 686.0431979999412 686.7206969999243 689.3544590000529 692.1098929999862 692.7113270000555 693.3363659998868 697.273736000061 697.9527010000311 705.564800000051 707.5746520000976 721.6517449999228 722.8983080000617 725.5740920000244 727.0210210001096 735.3770089999307 736.1825649999082 747.0081819999032 748.1631859999616 755.620360000059 760.9885750000831 763.9035080000758 765.5808419999667 775.2652050000615 794.3133189999498
Open Search Page TTI	Baseline Mean: 602.616 ms Stdev: 23.571 ms (3.9%) Runs: 569.9425460000057 573.1754159999546 574.5434980001301 576.6577559998259 577.8909099998418 579.6537269998807 580.1073409998789 582.4493410000578 582.682373000076 584.8663739999756 587.3177090000827 587.8253179998137 589.9990640000906 592.3848880000878 593.2575280000456 595.4763189998921 598.7990719999652 599.6527510001324 600.8334960001521 605.9797769999132 612.1350920000114 612.998292000033 615.2581790001132 615.4576419999357 617.0260819999967 618.2544759998564 618.7037760000676 619.4840910001658 625.1932380001526 639.6750079998747 640.4772129999474 653.3242600001395 664.8568939999677 Current Mean: 610.524 ms Stdev: 23.602 ms (3.9%) Runs: 574.413290000055 581.8197840000503 585.3350829998963 585.8043219998945 586.020549000008 587.5162349999882 589.6162520002108 590.2288420000114 593.648925999878 593.9017340000719 595.6807049999479 598.8166510001756 599.2316900000442 600.8096519999672 602.5615640000906 603.703125 605.0915530000348 607.6485999999568 608.7307539999019 609.8044030000456 610.5805260001216 611.7515470001381 618.0483810000587 618.9598399999086 631.3097330001183 632.8442800000776 633.0869549999479 633.947021999862 634.0214439998381 636.2144780000672 644.9126790000591 669.3377280000132 671.9085699999705
App start regularAppStart	Baseline Mean: 0.014 ms Stdev: 0.000 ms (2.8%) Runs: 0.013590000104159117 0.013794000027701259 0.01387499994598329 0.013998000184074044 0.014038000022992492 0.014079000102356076 0.014160000020638108 0.014160000020638108 0.014201000100001693 0.014241000171750784 0.014404000015929341 0.014445000095292926 0.014484999934211373 0.014485000167042017 0.014526000013574958 0.014526000013574958 0.014526000013574958 0.014527000021189451 0.014649000018835068 0.014689000090584159 0.0147299999371171 0.014771000016480684 0.014812000095844269 0.014892000006511807 0.015299000078812242 0.015300000086426735 Current Mean: 0.015 ms Stdev: 0.001 ms (5.3%) Runs: 0.013509000185877085 0.013712999876588583 0.013752999948337674 0.014038000022992492 0.014079000102356076 0.014200999867171049 0.01424099993892014 0.014282000018283725 0.01432300009764731 0.01432300009764731 0.014362999936565757 0.014362999936565757 0.01436399994418025 0.014364000177010894 0.014404000015929341 0.014445000095292926 0.014445000095292926 0.014689000090584159 0.0147299999371171 0.0148930000141263 0.015054999850690365 0.015137000009417534 0.015420999843627214 0.015503000002354383 0.015542999841272831 0.015583999920636415 0.015705999918282032 0.01595099992118776 0.01607199991121888 0.016967999981716275
App start nativeLaunch	Baseline Mean: 19.759 ms Stdev: 1.568 ms (7.9%) Runs: 17 18 18 18 18 18 18 18 19 19 19 19 19 19 20 20 20 20 21 21 21 21 21 21 21 21 22 23 23 Current Mean: 19.742 ms Stdev: 1.523 ms (7.7%) Runs: 17 18 18 18 18 18 18 18 19 19 19 19 19 19 19 20 20 20 20 20 20 21 21 21 21 21 22 22 22 22 23
App start runJsBundle	Baseline Mean: 200.563 ms Stdev: 24.176 ms (12.1%) Runs: 161 164 170 173 174 176 178 181 184 187 187 191 192 192 193 197 199 200 202 203 204 207 210 220 220 224 224 225 232 240 247 261 Current Mean: 194.500 ms Stdev: 20.605 ms (10.6%) Runs: 165 166 167 169 172 173 174 179 184 185 185 188 189 192 196 196 196 197 197 197 200 200 203 205 207 221 224 227 227 254

[OSBotify]

🚀 Deployed to staging by https://github.com/pecanoro in version: 1.2.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.61-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅